Skip to content

quest(audio-codecs): ADTS export refuses what it cannot label - #4202

Merged
kixelated merged 1 commit into
quest/m1/audio-codecs/READMEfrom
plan/audio-codecs-adts-refusals
Sep 26, 2026
Merged

kixelated merged 1 commit into
quest/m1/audio-codecs/READMEfrom
plan/audio-codecs-adts-refusals

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

#4178 found two silent ADTS mislabels: an unrepresentable channel count falls back to stereo, and SBR/PS object types are masked.

Approach

Adds quest/m1/audio-codecs/adts-refusals.md [S].

Impact

  • None (quest docs only).

Alternatives

  • None.

Follow-ups

  • None.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-09-25T22:45:13.601761Z 68a9727 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

MERGE

Positive improvement: this quest pins two real silent ADTS mislabels found in #4178 (unrepresentable channel counts falling back to stereo; SBR/PS object types masked into the wrong profile) and turns them into an explicit refuse-or-label-correctly contract for moq-mux's ADTS writer. That is the right correctness stance for a mux path.

Worth the complexity: [S], docs only, and the plan is concrete (refuse unnamable channel counts the same way channelConfiguration 11–14 already does; decide per HE-AAC/HE-AACv2 case whether the AAC-LC core is a valid implicit-SBR signal or refuse; fixture + ffprobe tests). No public API or wire change beyond stopping the mislabels.

Different approach: jumping straight to a code fix without a quest would also work, but this matches how the audio-codecs track is already staged, and writing the refusal policy before the patch makes the review bar clearer. Optional polish later: name the exact moq-mux symbols/paths in the plan bullets so the implementer does not have to rediscover them.

Recommendation: merge.

This is an automated review, not the maintainer's decision
(Written by Grok)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated force-pushed the plan/audio-codecs-adts-refusals branch from 68a9727 to 5a4d95d Compare September 26, 2026 00:11

Copy link
Copy Markdown
Collaborator Author

Landing the ADTS-refusal quest note on quest/m1/audio-codecs/README.

Rebased onto c6ec06776 after #4178 and #4183. The README conflict was those two quests dropping their index lines (PCE export and the encode seam). Kept the ADTS-refusal bullet and adts-refusals.md; did not replay either PR.

(Written by Grok 4.7)

@kixelated
kixelated merged commit 0e8a5e8 into quest/m1/audio-codecs/README Sep 26, 2026
3 checks passed
@kixelated
kixelated deleted the plan/audio-codecs-adts-refusals branch September 26, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant