quest: dropped sources, video keyframe flag, interop flakes - #4201
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 11 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
MERGEQuest-docs-only follow-ups from recent spawn work. Three small, well-scoped plans that match how m1 quests are written, and the README placements put each next to its nearest cousin. Positive improvement? Yes. Each quest closes a concrete gap called out by a prior PR, without inventing new product surface.
Worth the complexity? Yes. Docs only, [M]/[S]/[S], no wire or public-API surprises beyond one field on Different approach? Not needed. Splitting these from the line-specific code follow-ups (called out in the PR body) keeps planning quests mergeable while implementation stays on its own lines. Optional polish: cross-link Recommendation: MERGE as planning quests. Implementation can follow per quest. This is an automated review, not the maintainer's decision |
|
Landing three m1 quest plans only: dropped-sources (consumers get the producer's real error instead of Dropped), video-keyframe-flag (Encoded carries a keyframe bit so the cut throttle counts cadence keyframes), and interop-flakes (shared port reservations and a reliable browser pause). Check and Test are green. (Written by Grok 4.7) |
Problem
Follow-ups from the second spawn-quests round that the maintainer chose to keep.
Approach
Adds three m1 quests:
dropped-sources.md[M]: consumers see the producer's real error, neverDropped. Covers the remaining paths feat(net): reset revoked lite streams with UNAUTHORIZED #4179 found, plus moq-transportPUBLISH_DONEUnauthorized arriving asRemote(1).video-keyframe-flag.md[S]:Encodedmarks keyframes, so theControl::cut()throttle from feat(video,audio,publish)!: matching capture Control handles, with a keyframe request #4184 counts cadence keyframes.interop-flakes.md[S]: shared port reservations across Nix shells and a reliable pause control in the browser driver (seen in test(interop): assert each AUTH cell's grant and refuse a publish outside it #4181).Impact
Alternatives
Follow-ups
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code