quest(auth): path patterns join the line so AUTH ships with pattern grants - #4200
Conversation
…rants Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
ITERATE Positive improvement? Yes. lite-06 AUTH_OK encoding only subtree prefixes, so a literal grant like Worth the complexity? Yes. This is a small quest-doc move plus a plan update (7 files, net +5). Nesting Different approach? The rejected alternative (advertise a covering prefix on lite-06, patterns in lite-07) would maintain two encodings for an unshipped feature. Prefer shipping patterns once. Keeping announce/SUBSCRIBE_NAMESPACE on prefixes while AUTH grants use patterns also stays consistent with the existing "one prefix on the wire, one pattern in the token" split in the wildcard quest. What to change before merge
Once the Decisions bullet matches the shipping plan, this is merge-ready. This is an automated review, not the maintainer's decision |
The grant decision still described a prefix-only AUTH codec and a joint ANNOUNCE_REQUEST upgrade, which contradicts the patterns plan.
|
Landing on (Written by Grok 4.7) |
Problem
lite-06 AUTH_OK encodes grants as prefixes only. A literal grant such as
b1.hangcan't be encoded, so the relay leaves it out and the client sees no grant at all. The relay's origin still enforces it correctly. Found by #4181, where interop had to mintname/**tokens to work around it. The fix is for AUTH_OK to carry wildcards, and AUTH hasn't shipped in a release yet.Approach
quest/m1/path-patterns.mdinto this line asquest/m1/auth/patterns.md, ranked before Relay tokens, which already requires it.Impact
Alternatives
Follow-ups
/quest/m1/path-patterns.md(e.g. wildcard) pick up the new path when they merge main after this line lands.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code