Skip to content

fix(ffi): name the binary config type at catalog call sites - #4171

Closed
kixelated wants to merge 1 commit into
mainfrom
fix/ffi-binary-stream-into
Closed

kixelated wants to merge 1 commit into
mainfrom
fix/ffi-binary-stream-into

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

cargo test -p moq-ffi --no-run failed on main with E0283 at both binary_snapshot and binary_stream call sites: config.into() can't infer a target because those methods take impl IntoRendition<E, BinaryConfig>, a blanket impl over any RenditionConfig + AsMut<BinaryConfig>. Name moq_mux::binary::Config explicitly.

No public API or wire impact.

Verified with just check.

🤖 Generated with Claude Code

(written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review September 25, 2026 19:13
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T19:15:24.891435Z 1396818 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4e845345-223f-41ed-a2df-84e33d113e41

📥 Commits

Reviewing files that changed from the base of the PR and between e173ddd and 1396818.

📒 Files selected for processing (1)
  • rs/moq-ffi/src/binary.rs

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


Walkthrough

The binary FFI module imports moq_mux::binary::Config and uses that name in its conversion implementation. The snapshot and stream publishing methods now call Config::from(config). The configuration behavior is unchanged.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 13968

This change makes the binary configuration conversion target explicit without indicating a behavior change; no actionable merge risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the fix: naming the binary configuration type at FFI catalog call sites.
Description check ✅ Passed The description directly explains the type-inference error, the affected call sites, the fix, and verification results.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Superseded by #4157, which is already on main (1a4f8e26a, "fix(ffi): name the binary config conversion so moq-ffi compiles"). Both binary_snapshot and binary_stream already call moq_mux::binary::Config::from(config). Rebasing this PR onto main leaves an empty commit, so closing it as the landing.

(Written by Grok 4.7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant