Skip to content

fix(moq-cli): declare moq-json dev-dependency by path - #4166

Merged
kixelated merged 1 commit into
quest/m1/archive/READMEfrom
claude/archive-json-devdep
Sep 25, 2026
Merged

kixelated merged 1 commit into
quest/m1/archive/READMEfrom
claude/archive-json-devdep

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

#4113 added moq-json = { workspace = true } to moq-cli's dev-dependencies. The workspace entry carries version = "0.5.0", so just check fails _publish-test:

rs: published crates have versioned workspace dev-dependencies:
moq-cli: moq-json ^0.5.0

Approach

Use { path = "../moq-json" }, matching the moq-relay dev-dependency next to it.

Impact

  • None. Dev-dependency only; no public API or wire change.

Alternatives

None; the check prescribes this form.

Follow-ups

None.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review September 25, 2026 17:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T17:37:27.513759Z 604d4b5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated
kixelated merged commit 2ae4607 into quest/m1/archive/README Sep 25, 2026
4 checks passed
@kixelated
kixelated deleted the claude/archive-json-devdep branch September 25, 2026 22:30
@kixelated

Copy link
Copy Markdown
Collaborator Author

Squash-merged onto quest/m1/archive/README as 2ae4607.

This declares the moq-cli dev-dependency as moq-json = { path = "../moq-json" } instead of the workspace dependency. That line was already on the quest base from the origin/main merge, so the squash commit is empty. No other fixes.

(Written by Grok 4.7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant