Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ose/README # Conflicts: # doc/lib/rs/moq-net.md # js/net/src/origin.ts # rs/moq-net/src/model/broadcast.rs # rs/moq-net/src/model/origin.rs
…4127) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…se/remove # Conflicts: # quest/m1/README.md # rs/moq-ffi/src/test.rs
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
kixelated
marked this pull request as ready for review
September 26, 2026 00:16
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The line #4031 made
close()the one way to end a broadcast and deprecated the finished-versus-aborted split, which never survives a hop (a broadcast has no FIN on the wire). The deprecated APIs still need removing ondev, andclosed()still carries anErrorcause nobody can act on.Depends on #4031 reaching
mainand thendev. This branch mergesquest/m1/broadcast-close/READMEintodevso the deprecations exist to remove; until #4031 lands andmainmerges intodev, the diff here includes the line's commits (#4047, #4126). Kept as a draft until then.Approach
moq-net: dropbroadcast::Producer::finish,abort,Consumer::is_finished, and thefinished/abortstate they read.Consumer::closed(),Dynamic::closed(), andDynamic::poll_closednow return().moq-ffi/libmoq: dropMoqBroadcastProducer::finishandmoq_publish_finish.finish(), Swiftfinish(), GoFinish(); Dart regenerated.broadcast.Producer.close(abort)/Consumer.close(abort);closednarrows toGetPromise<null>.broadcast.end(), via auniffi.tomlrename of the generatedclose()(replacing the old exclude). Kotlin'sclose()/use {}isAutoCloseableand only releases the handle, which ends the broadcast once nodynamic()handle remains. Withoutfinish(), a Kotlin app holding adynamic()serving loop would have no way to end the broadcast short of cancelling that loop. A distinct name is the cheapest fix that keeps the Rust semantics; the quest's Plan records it.Impact
moq-net(breaking):broadcast::Producer::{finish, abort}andbroadcast::Consumer::is_finishedremoved;broadcast::Consumer::closed()andbroadcast::Dynamic::{closed, poll_closed}return()instead ofError.moq-ffi(breaking):MoqBroadcastProducer.finish()removed from every binding. Kotlin gainsMoqBroadcastProducer.end()(the forced end), sinceclose()there isAutoCloseable.libmoqC ABI (breaking):moq_publish_finishremoved; usemoq_publish_close.BroadcastProducer.finish(), SwiftBroadcastProducer.finish(), GoBroadcastProducer.Finish()removed.@moq/net(breaking):broadcast.Producer.close(abort)andbroadcast.Consumer.close(abort)lose the parameter;closedisGetPromise<null>.moq-transcode: an idle rung whose source broadcast closes now aborts its output withError::Droppedexplicitly (it was alwaysDroppedin practice).Alternatives
dynamic()handle must be closed too. Rejected: a serving loop blocked inrequestedTrack()only returns once the broadcast ends, so the two wait on each other.close()a forced end, but changes drop semantics for Python, Swift, Go, and Dart apps that keep serving throughdynamic()after releasing the producer.closeBroadcast(),shutdown()):end()is shortest and matches the docs' wording.Testing
Rust nextest (4384 pass), JS, Python, Go, Dart, and Kotlin checks pass locally; Kotlin gains a test that
end()ends a broadcast while adynamic()handle is still open. Swift is uncompiled locally (Linux).Follow-ups
removechild keeps quest(broadcast-close): Broadcast close #4031 a draft while this PR waits on quest(broadcast-close): Broadcast close #4031: the line'sQuestslist should drop this child (it lands ondevseparately) so quest(broadcast-close): Broadcast close #4031 can be sized and merged. Deletequest/m1/broadcast-close/remove.mdand its README entry here once that is sorted.end()is additive and could ship onmainahead of this removal.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code