Skip to content

test(signals): deflake the spawn retention test #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kixelated wants to merge 1 commit into from
Closed

test(signals): deflake the spawn retention test #4135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions js/signals/src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1209,9 +1209,14 @@ describe("spawn retention", () => {
return heapStats().objectTypeCounts.Promise ?? 0;
};

// Settle each task before the next, like a per-group spawn. Spawning all at once would grow
// the task set through rehashes, and JSC leaves the old tables' keys in place: a stale
// conservative stack word pointing at one keeps ~8k dead promises alive.
const before = promises();
for (let i = 0; i < 10000; i++) effect.spawn(async () => {});
await settle();
for (let i = 0; i < 10000; i++) {
effect.spawn(async () => {});
await settle();
}
expect(promises() - before).toBeLessThan(100);
effect.close();
});
Expand Down