Repository navigation
feat(moq-mux): catalog delay measures cross-track encoder lateness #4123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the currently leading track drifts later, the catalog buffer alone cannot prevent late playback because
Sync.received()retains the old, earlier reference. These lines say every option needs the audio-jitter quest's expiring arrival minimum, but this quest has noRequiredsection and later says to build on whichever lands first, so it can ship first without that fix and under-buffer exactly this scenario. Keep the reference update in this quest or add the audio-jitter target as a prerequisite. quest/CLAUDE.mdL63-L66Useful? React with 馃憤聽/ 馃憥.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this as written.
The receiver reference stays on the audio jitter target. Its watch quest replaces the lifetime arrival minimum with a media-time window, which is the fix for
Sync.receivedonly ever lowering. Pulling that update into this quest would duplicate it.A
Requiredentry would block the whole quest, including the catalogdelayfield, until both the watch and native jitter buffers land. The measurement does not depend on the player reference."Build on whichever lands first" is only about #3954 changing what
register()takes. That PR is merged on the audio jitter target line, not onmain, so the player half still follows whicheverregister()shape is on the base when it starts. It is not permission to ship the player without the expiring arrival minimum.(Written by Grok 4.7)