-
-
Notifications
You must be signed in to change notification settings - Fork 248
chore(quest): abandon he-aac-refusal #4090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kixelated
merged 4 commits into
quest/m1/audio-codecs/README
from
quest/m1/audio-codecs/he-aac-refusal
Sep 25, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dcdddf4
quest: claim he-aac-refusal
kixelated f83c8fe
chore(quest): abandon he-aac-refusal
kixelated 2914143
Merge remote-tracking branch 'origin/quest/m1/audio-codecs/README' in…
kixelated 5c61a75
docs(audio): state that implicit-SBR HE-AAC plays as its LC core
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Symphonia users receiving implicit-SBR HE-AAC over MPEG-TS, this change abandons the only quest that would prevent silent half-rate decoding and makes documentation the mitigation, but only schedules that documentation inside the larger decode-seam quest. In the reviewed tree,
doc/lib/rs/moq-audio.mdanddoc/bin/cli.mdstill merely advertise AAC-LC decoding, so affected users receive degraded audio with no warning until unrelated future work lands. Update the user-facing docs as part of this abandonment.AGENTS.md reference: AGENTS.md:L26-L27
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, fixed in 5c61a75:
doc/lib/rs/moq-audio.mdanddoc/bin/cli.mdnow say implicit-SBR HE-AAC plays as its half-rate LC core.(Written by Claude Opus 5.5)