Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Ports main's changes to the recipes #4058 moved into sh/: - #4078: `check` runs the tests too, and `ci check|test` are CI's halves. sh/dispatch.sh gains `ci-check`/`ci-test`; `check` lints Rust through the new `rs check-test` (clippy-driver test build, build.warnings=deny) and then runs the js/py tests. - #4048: the media feature contracts run from sh/rs/select.sh when a media crate or the contract script changes; relay-minimal left the PR gate. - #4049: the C doc samples compile in sh/rs/c-tests.sh, the Python ones via sh/py/samples.sh, and doc/lib paths join the py/kt/swift impact map. - #4069: sh/drafts/check.sh refuses tabs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged
Verified locally: stubbed dry runs of (written by Claude Opus 5.5) |
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…4174) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Grok 4.7 <noreply@x.ai>
|
Warning Review limit reachedNext included review available in 6 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (149)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b76b6460b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return | ||
| fi | ||
|
|
||
| grep -q '^rs/' "$list" || return 0 |
There was a problem hiding this comment.
When a PR changes only sh/rs/tokio-features.sh, the root dispatcher selects the Rust module, but select_packages returns here because the changed-file list contains no rs/ path. CI then reports rs: no crates affected; skipping. and never executes the modified feature-matrix script, so broken commands can merge without any functional test. Treat this path as selecting the Tokio feature gate, as is already done for media-features.sh.
AGENTS.md reference: AGENTS.md:L23-L23
Useful? React with 👍 / 👎.
| declare -A scope=( | ||
| [js]='^(js/|doc/|drafts/|demo/(boy|web)/|test/interop/clients/js|test/wasm/|sh/js/|sh/rs/stats-docs\.py$|package\.json$|bun\.lock(b)?$|biome\.jsonc$)' | ||
| # Workers with lockfiles outside the Bun workspace. | ||
| [workers]='^(infra/apt/|infra/rpm/|demo/pub/|sh/js/workers\.sh$)' |
There was a problem hiding this comment.
When only js/justfile changes, it matches the main JS scope but not this worker scope, so CI runs the Bun workspace checks without invoking just js workers. This drops the previous behavior where a js/justfile edit exercised all three worker deploy dry-runs, allowing a broken worker recipe or script path to pass until after merge. Include js/justfile in this pattern.
AGENTS.md reference: AGENTS.md:L23-L23
Useful? React with 👍 / 👎.
This branch has not been deployed
1 participant
Questline branch for /quest/m1/tooling/README.md. Child quests merge here; this stays a draft until the line's
Questslist is empty.(written by Opus 5.5)
🤖 Generated with Claude Code