quest(archive): Timeline-indexed MoQ archives by kixelated · Pull Request #4034 · moq-dev/moq

kixelated · 2026-09-24T17:31:02Z

Questline branch for /quest/m1/archive/README.md. Child quests merge here; this stays a draft until the line's Quests list is empty.

(written by Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

# Conflicts: # rs/moq-json/src/window/mod.rs

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

… archive` (#4113) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Grok 4.7 <noreply@x.ai>

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

…4115) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Grok 4.7 <noreply@x.ai>

#4155) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

chatgpt-codex-connector · 2026-09-26T00:11:05Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-26T00:16:57.221569Z	`d605937`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-09-26T00:11:06Z

Warning

Review limit reached

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 5661cd61-c2c4-4d78-ae27-66e73127fa11

📥 Commits

Reviewing files that changed from the base of the PR and between e173ddd and d605937.

⛔ Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (52)

Cargo.toml
doc/bin/cli.md
doc/bin/hls.md
js/json/src/window/encoder.ts
js/json/src/window/producer.ts
js/json/src/window/window.test.ts
quest/m1/archive/README.md
quest/m1/archive/browser.md
quest/m1/archive/dvr.md
quest/m1/archive/hls.md
quest/m1/archive/proof.md
quest/m1/archive/pruning.md
quest/m1/archive/reader.md
quest/m1/archive/replay-catalog.md
quest/m1/archive/track-timeline/README.md
quest/m1/archive/track-timeline/core.md
quest/m1/archive/track-timeline/js.md
quest/m1/archive/writer.md
quest/m2/README.md
quest/m2/archive-s3.md
rs/moq-archive/Cargo.toml
rs/moq-archive/src/error.rs
rs/moq-archive/src/lib.rs
rs/moq-archive/src/mock.rs
rs/moq-archive/src/path.rs
rs/moq-archive/src/proof.rs
rs/moq-archive/src/reader/index.rs
rs/moq-archive/src/reader/mod.rs
rs/moq-archive/src/reader/tests.rs
rs/moq-archive/src/recover.rs
rs/moq-archive/src/segment.rs
rs/moq-archive/src/store.rs
rs/moq-archive/src/writer.rs
rs/moq-cli/Cargo.toml
rs/moq-cli/README.md
rs/moq-cli/src/archive.rs
rs/moq-cli/src/args.rs
rs/moq-cli/src/hls.rs
rs/moq-cli/src/main.rs
rs/moq-cli/src/subscribe.rs
rs/moq-hls/Cargo.toml
rs/moq-hls/src/export/archive_tests.rs
rs/moq-hls/src/export/mod.rs
rs/moq-hls/src/export/mpd.rs
rs/moq-hls/src/export/rendition.rs
rs/moq-hls/src/export/renditions.rs
rs/moq-hls/src/export/segments.rs
rs/moq-json/src/window/encoder.rs
rs/moq-json/src/window/mod.rs
rs/moq-json/src/window/producer.rs
rs/moq-mux/src/error.rs
rs/moq-mux/src/timeline.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6059370ff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-26T00:16:55Z

+				Err(err) => {
+					tracing::warn!(track = %name, %err, "track ended");
+					track.subscribed = false;


Return source subscription failures

When an enrolled track's recv_group returns an error, this branch converts the failure into a clean track ending, so Writer::run can ultimately return Ok(()) if the broadcast itself finishes normally. Any remaining groups on that track are silently absent from an archive reported as successful; propagate the source error instead of treating it like Ok(None).

AGENTS.md reference: AGENTS.md:L17-L18

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-09-26T00:16:55Z

+			tokio::time::sleep(interval).await;
+			reader.refresh().await?;


Reject a zero follow interval

When the user passes --follow 0s, the duration parser accepts zero and this loop repeatedly sleeps for zero duration and calls reader.refresh(), continuously listing the object store. This can hammer a remote S3/GCS/Azure backend and accrue substantial request load, so reject a zero interval before entering the loop.

AGENTS.md reference: AGENTS.md:L17-L18

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-09-26T00:16:55Z

+stage ends once the broadcast does, and it refuses a store URL that already
+holds a recording. `--retention 1h` keeps only the last hour (a DVR),


Correct the existing-recording behavior in the CLI docs

The CLI passes the store directly to Writer::new, which now explicitly recovers and resumes an existing recording rather than refusing it. This statement can cause an operator to reuse a prefix expecting a safe failure; if the new source restarts group numbering, the resume floor silently skips its earlier groups. Document the resume and numbering constraints, or restore a CLI-level occupancy check.

AGENTS.md reference: AGENTS.md:L27-L27

Useful? React with 👍 / 👎.

kixelated and others added 15 commits September 24, 2026 10:30

quest: open the archive line

0631611

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(moq-archive): record selected broadcast tracks with a Writer (#4043

3f42dce

) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

feat(archive): serve recordings through a supplied broadcast (#4044)

62a4821

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into quest/m1/archive/README

00282ce

# Conflicts: # rs/moq-json/src/window/mod.rs

Merge remote-tracking branch 'origin/main' into quest/m1/archive/README

9737274

fix(archive): fail the writer on malformed source input (#4088)

a03664b

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

feat(cli): record and replay archives with export archive / `import…

eb55c52

… archive` (#4113) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Grok 4.7 <noreply@x.ai>

feat(archive): resume a recording on restart (#4114)

fc61e33

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

test(hls): serve archive recordings as HLS from the timeline alone (#…

c6644ea

…4115) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Grok 4.7 <noreply@x.ai>

feat(moq-hls): list a durable archive timeline without the live window (

25a852d

#4155) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Merge origin/main into quest/m1/archive/README

c9ab185

quest(archive): per-track timelines and replay catalog (#4168)

fb1f7f6

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Merge quest/m1/archive/README

a20a784

fix(moq-cli): declare moq-json dev-dependency by path (#4166)

2ae4607

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

test(archive): prove recording, replay, and retention end to end (#4169)

d605937

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

kixelated marked this pull request as ready for review September 26, 2026 00:10

chatgpt-codex-connector Bot reviewed Sep 26, 2026

View reviewed changes

Navigation Menu

Uh oh!

quest(archive): Timeline-indexed MoQ archives - #4034

quest(archive): Timeline-indexed MoQ archives#4034
kixelated wants to merge 15 commits into
mainfrom
quest/m1/archive/README

kixelated commented Sep 24, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 26, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 26, 2026

Review limit reached

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Sep 26, 2026

Uh oh!

chatgpt-codex-connector Bot Sep 26, 2026

Uh oh!

chatgpt-codex-connector Bot Sep 26, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		stage ends once the broadcast does, and it refuses a store URL that already
		holds a recording. `--retention 1h` keeps only the last hour (a DVR),

Uh oh!

Conversation

kixelated commented Sep 24, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Sep 26, 2026

Review limit reached

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 26, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Sep 26, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Sep 26, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chatgpt-codex-connector Bot commented Sep 26, 2026 •

edited

Loading