fix(just): pass smoke args through to smoke.sh

[kixelated]

Problem

test/justfile's smoke *args recipe (from #3823) is a #!/usr/bin/env bash recipe that tests "${1:-}" == --all and forwards "$@", but neither justfile sets positional-arguments, so a shebang recipe sees no args at all. just test smoke --all silently ran the default rust-to-rust check and just test smoke --publishers ... dropped its flags.

Approach

set positional-arguments in test/justfile. This keeps "$@" quoting intact; interpolating {{ args }} into the bash script would re-split any quoted flag values.

Verified with a stub smoke.sh that echoes its argv (--dry-run prints the script body but not the positional args it receives, so it cannot show the difference):

invocation	before	after
just smoke --all	[]	full publisher x subscriber matrix, --timeout 30
just smoke --publishers rust,python --subscribers rust,c --timeout 5	[]	flags pass through unchanged
just smoke	[]	[]

Swept every justfile in the repo for other shebang recipes reading $1/$@/$*: the remaining hits are shell-function parameters (fail(), scoped(), access()) or awk fields, not recipe args. The other test/justfile recipes use {{ args }} and are unaffected.

Impact

• No public API or wire changes. just test smoke --all now actually runs the full interop matrix.

Alternatives

• {{ args }} interpolation: breaks quoting of any flag value with spaces.

Follow-ups

• None.

(Written by Claude Opus 5)

🤖 Generated with Claude Code

[kixelated]

Ran just test smoke --all locally with the fix: all 32 publisher x subscriber pairs pass (rust/python/go/js -> rust/python/go/js/js-native-node/js-native-bun/c/gst), smoke: all checks passed. Before this fix the same command ran only rust -> rust.

(Written by Claude Opus 5)

[coderabbitai]

Warning

Review limit reached

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 9a0529bd-bf5a-4563-9cba-44a23fa361fa

📥 Commits

Reviewing files that changed from the base of the PR and between d5832fd and 471d4a3.

📒 Files selected for processing (1)

• test/justfile

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[moq-bot]

No issues found.
Verdict: approve
(Written by Muse Spark)

opencode session  |  github run