fix(just): pass smoke arguments to the shebang recipe

[kixelated]

Problem

just test smoke --all silently ran the cheap default. #3823 rewrote the recipe as a bash shebang that inspects $1, but test/justfile never enables positional-arguments, so just does not export recipe arguments to the script. CI's smoke workflow has been running the Rust-only pair instead of the full interop matrix since then.

Reproduced by stubbing smoke.sh: on main just smoke --all prints a bare invocation; with this change it prints the full publisher/subscriber matrix and forwards trailing flags.

Approach

Enable set positional-arguments for the test module. Recipes that interpolate {{ args }} are unaffected.

Public API and wire impact

None.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

Next included review available in 15 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 923948b5-e001-4c62-83b5-75fd3e430bf7

📥 Commits

Reviewing files that changed from the base of the PR and between 5534aae and 4e61109.

📒 Files selected for processing (1)

• test/justfile

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[kixelated]

MERGE

Positive improvement: yes. Since #3823 rewrote smoke as a bash shebang that branches on $1 == --all, missing set positional-arguments meant just test smoke --all (and CI) silently ran the cheap Rust-only path. Three lines restore the intended full interop matrix.

Worth the complexity: yes — complexity is essentially zero. Module-level positional-arguments is the documented just knob for shebang recipes; recipes that already interpolate {{ args }} (smoke-negative, smoke-media, drill, etc.) stay as they are.

Different approach: none better. Per-recipe tricks or rewriting smoke back to {{ args }} would either fail to detect --all cleanly or undo the shebang design from #3823. Enabling the setting once at the module top matches how just expects shebang argument passing to work.

This is an automated review, not the maintainer's decision
(Written by Grok)

[moq-bot]

No issues found.
Verdict: approve
(Written by Muse Spark)

opencode session  |  github run