Repository navigation
quest(future): restore the Go docs' vanity paths after the mirrors republish - #3851
Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. WalkthroughAdds a future quest link for “Go vanity docs.” The new quest document records the required mirror module declaration, the planned revert of PR Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The PR adds deferred quest documentation only and is mergeable. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No issues found. |
|
MERGE Positive improvement: yes. #3847 was a temporary docs workaround while mirrors still declare the old Worth the complexity: yes — quest file plus an m1 index line, no code. The Required bullet names the real condition (mirror declares Different approach: doing the revert inside the release PR itself would also work, but a quest matches how this repo tracks deferred cleanup, and the write-up of why pkg.go.dev 404s is useful on its own.This is an automated review, not the maintainer's decision |
…publish Gated on the next Go mirror release, so it waits under quest/future per quest/README.md. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
9a535eb to
9cb65ae
Compare
|
No issues found. |


Problem
#3847 swapped the badge,
import, and API reference indoc/lib/go/index.mdtogithub.com/moq-dev/moq-gobecausepkg.go.dev/moq.dev/moq404s. The vanity path itself works (moq.dev/moq?go-get=1serves thego-importtag, the proxy lists versions). The gap is release ordering: the rename tomodule moq.dev/moq(#2957) reachedmainon 2026-09-20 via the dev merge (#3793), three days after the lastmoq-ffi-v0.3.19tag, so every mirror tag still declares thegithub.com/...paths andgo get moq.dev/moqfails on the path mismatch.release-go.ymlalready defers on everymainpush for exactly this reason, waiting on themoq-ffi-v0.4.0tag from #3730. Without a quest the revert gets lost.Approach
Add
quest/future/go-vanity-docs.mdholding the condition as a plain-textRequiredbullet: when it clears, revert #3847 and verify both pkg.go.dev pages return 200.Placement: #3855 renamed the quest tree after this PR opened.
quest/future/README.mdis where a quest gated on the outside world (an upstream release) waits with its condition as a plain-textRequiredbullet, and this is a docs revert, not a published API break, so it does not belong underdev. It ranks first infuturebecause it is the only entry with a concrete near-term trigger and is XS.Relatednow points at/quest/dev/release.md.Impact
futureindex only.Alternatives
quest/main: rejected,mainholds work landing now and this cannot start until the mirrors republish./quest/dev/release.mdinstead of the plain-text bullet: rejected, the Go mirror republishes on the nextmoq-ffi-v*tag, which release-plz can cut before the release moq.pro adopts.Follow-ups
🤖 Generated with Claude Code