Skip to content

chore(quest): retire completed announce scope work - #3797

Open
kixelated wants to merge 1 commit into
mainfrom
codex/cleanup-completed-m1-quests
Open

kixelated wants to merge 1 commit into
mainfrom
codex/cleanup-completed-m1-quests

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

The announce-event and origin-scope quests remain in the living tree even though #3770 and #3746 completed them. Their stale blockers keep dependent quests from reporting ready.

Approach

  • Delete both completed m1 quests and their m1 index entries.
  • Replace historical quest links with the landed PRs.
  • Remove the completed blockers from dependent quests.

Impact

Alternatives

Keeping completed quest files was rejected because quests are deleted when their work lands.

Follow-ups

None.

Validation: nix develop --command just check; quest check reports 393 documents OK.

(written by GPT-6 Astra)

Co-Authored-By: GPT-6 Astra <noreply@openai.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

MERGE

Positive improvement: yes. #3770 and #3746 already landed the announce-prefix and origin-scope work; leaving those m1 quests in the tree only keeps stale Required blockers on dependents. Deleting the completed quests, dropping them from the m1 index and review-gate list, and pointing historical links at the landed PRs is the right hygiene.

Worth the complexity: yes, and the complexity is low. Diff is quest-graph only (no Public API / wire), deletions dominate, and each dependent edit either removes a completed blocker or swaps a dead quest path for the PR that closed it. That matches the stated rule that quests are deleted when their work lands.

Different approach: none better. Keeping completed quest files as archive would fight the living-tree model and leave dependents blocked. A softer “mark done” status would still leave Required edges unless those were cleared anyway, so delete-and-relink is the direct fix.

This is an automated review, not the maintainer's decision
(Written by Grok)

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 280e225c-3616-4f40-84b1-7075733013ba

📥 Commits

Reviewing files that changed from the base of the PR and between b2ef453 and f5ff53d.

📒 Files selected for processing (13)
  • quest/m1/README.md
  • quest/m1/api-net-announce.md
  • quest/m1/api-origin-scopes.md
  • quest/m1/api-review-gate.md
  • quest/m2/js-net-additive.md
  • quest/m2/net-ingest-source.md
  • quest/m2/origin-cpu/origin-tree.md
  • quest/m2/origin-narrowing.md
  • quest/m2/path-patterns/interest.md
  • quest/m2/processor/advertise-auth.md
  • quest/m2/wildcard/README.md
  • quest/m2/wildcard/resolve.md
  • quest/m3/cat/verify.md
💤 Files with no reviewable changes (5)
  • quest/m1/README.md
  • quest/m2/wildcard/resolve.md
  • quest/m2/processor/advertise-auth.md
  • quest/m1/api-origin-scopes.md
  • quest/m1/api-net-announce.md

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.


Walkthrough

The pull request updates quest documentation only. It removes completed M1 quest specifications and list entries. It replaces related M2 references with links to pull requests or remaining prerequisites. It updates the M3 CAT verification plan to reflect landed pattern scopes.

Priority: ⬇️ Low

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that the completed announce-scope quest work is being retired, which matches the main documentation changes.
Description check ✅ Passed The description accurately explains the removal of completed quests, link updates, blocker removal, and the absence of API or wire changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@moq-bot

moq-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

No issues found.
Verdict: approve
(Written by Muse Spark)

New%20session%20-%202026-09-20T13%3A17%3A39.825Z
opencode session  |  github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant