-
-
Notifications
You must be signed in to change notification settings - Fork 248
docs: prove the unpublished dev API through smoke #3664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,10 +45,28 @@ merge for it. The rest of the archive line, wildcard resolution, and every | |
| additive quest that builds on dev-only code start on main afterwards from | ||
| [m2](/quest/m2/README.md). | ||
|
|
||
| The 2026-09-12 external API audit is closed. Proof is | ||
| [moq-dev/smoke](https://github.com/moq-dev/smoke) `./dev.sh` (unpublished | ||
| `dev` checkout, not crates.io/npm latest) plus | ||
| `rs/moq-relay/tests/embed.rs` for custom routes and origin workers. | ||
|
Comment on lines
+48
to
+51
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "The audit is closed" plus dropping this quest from Required is stronger than the evidence in this PR. The packaged-consumer proof is moq-dev/smoke#36, which is still open, and that job checks out The original gate was "fixture in CI + exact revisions." Pointing at Also say what smoke does not cover: JS-only against a local relay, no native crate consumer, no two-copy package-identity case. Those were explicit non-goals after the smoke split; write that down so the next merge does not treat them as done. (Written by grok-4.6) |
||
| Embedding ownership of `workers`/`uring` stays on | ||
| [Relay embedding](/quest/m1/api-relay-embedding.md). | ||
|
|
||
| | Finding | Disposition | Revision | | ||
| |---|---|---| | ||
| | FFI pending reads serialize independent datagram/group lanes | Fixed: independent group and datagram lanes | `1f7b2b45b` (#3651) | | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The independent-lane fix is #3645 ( Cite #3645 as the disposition for this row (and #3651 only if you want the follow-up on the same line). As written, the table points at the wrong revision for the audit finding. (Written by grok-4.6) |
||
| | Shared/private connections disagree on credential-refresh recovery and terminal state | Fixed: one URL-recovery contract, `closed` is handle disposal | `b5a289a05` (#3636) | | ||
| | Relay embedding can discard newly added socket owners without a compile error | Deferred to [Embedding](/quest/m1/api-relay-embedding.md); `tests/embed.rs` covers routes and origin workers on the current load API | open | | ||
| | FFI first-frame convenience treats empty groups as EOF and loses an acquired group on cancellation | Deferred to [Frame cursor](/quest/m1/api-ffi-frame-cursor.md) | open | | ||
| | JSON/binary readers hide the subscription cleanup handle | Abandoned: finish must be `&mut` so abort can follow | `a8dbf886d` (#3637) | | ||
| | Local inclusive ends cannot express the empty exclusive range | Deferred to [Bounds](/quest/m1/api-subscription-bounds.md) | open | | ||
| | Typed Getter input can be rejected solely for lacking an internal brand | Fixed: `getter()` reuses any conforming Getter | `26b505995` (#3639) | | ||
| | JSON edit guard logs failed implicit publication | Fixed: `modify` refuses a closed track, a failed drop aborts it | `ff45019fc` (#3644) | | ||
| | Terminal publisher methods inconsistently retain the caller's handle | Deferred to [Finish borrows](/quest/m1/api-finish-borrow.md) | open | | ||
|
|
||
| ## Required | ||
|
|
||
| - [m0](/quest/m0/README.md) - every release blocker lands or is punted before the merge | ||
| - [External API proof](/quest/m1/api-release-proof.md) - the packaged consumer fixture and explicit fix/deferral decisions must be recorded before merge | ||
| - [Monotonic timeline](/quest/m1/monotonic-timeline.md) - so a shed marker still jumps the playhead on a timestamp hole (#3291) | ||
| - [Wildcard docs](/quest/m1/wildcard-docs.md) - the release that follows ships pattern advertisements, so their docs ship in it | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The imports shown above this new example define only
CatalogandContainer, but the example dereferencesJson. A consumer copying the documented migration receivesCannot find name 'Json'at build time, or aReferenceErrorin untyped JavaScript, before it can read the catalog. Add the@moq/jsonnamespace import to the snippet.Useful? React with 👍 / 👎.