Symptom
just check --all (CI Check job) fails to compile moq-relay:
error[E0308]: mismatched types
--> rs/moq-relay/src/uring.rs:761:10
|
761 | if let Err(err) = driver_handle.run(driver).await {
| ^^^^^^^^ ------------------------------- this expression has type `moq_net::Error`
| |
| expected `Error`, found `Result<_, _>`
Root cause
#3828 changed the driver run() return from D::Output (a Result) to moq_net::Error directly, and updated the call sites (e.g. rs/moq-relay/src/websocket.rs gained an ended() helper mapping Closed -> Ok). rs/moq-relay/src/uring.rs:761 was missed and still patterns the result with if let Err(err).
Blame: uring.rs last touched by #3825; the signature change landed in #3828 (d2f881bbb).
Suggested fix
Mirror the websocket.rs ended() pattern at the uring.rs:761 spawn: treat the returned moq_net::Error as a value, log non-Closed terminations, keep the clean-close silent as before.
Evidence it is mainline
Found while landing #3823, whose diff contains zero .rs source files (just/yml/md only), so it cannot have caused this. The failing file at the PR head is byte-identical to origin/main.
Impact
Blocks every PR: Check is a required status check for main. #3823 (Smoke/Test/WASM/review green) is parked on this.
(Written by Muse Spark)
Symptom
just check --all(CI Check job) fails to compilemoq-relay:Root cause
#3828 changed the driver
run()return fromD::Output(aResult) tomoq_net::Errordirectly, and updated the call sites (e.g.rs/moq-relay/src/websocket.rsgained anended()helper mappingClosed -> Ok).rs/moq-relay/src/uring.rs:761was missed and still patterns the result withif let Err(err).Blame:
uring.rslast touched by #3825; the signature change landed in #3828 (d2f881bbb).Suggested fix
Mirror the
websocket.rsended()pattern at theuring.rs:761spawn: treat the returnedmoq_net::Erroras a value, log non-Closedterminations, keep the clean-close silent as before.Evidence it is mainline
Found while landing #3823, whose diff contains zero
.rssource files (just/yml/md only), so it cannot have caused this. The failing file at the PR head is byte-identical toorigin/main.Impact
Blocks every PR:
Checkis a required status check formain. #3823 (Smoke/Test/WASM/review green) is parked on this.(Written by Muse Spark)