Skip to content

Check red on main: rs/moq-relay/src/uring.rs missed by #3828 driver run() signature change #3848

Description

@kixelated

Symptom

just check --all (CI Check job) fails to compile moq-relay:

error[E0308]: mismatched types
 --> rs/moq-relay/src/uring.rs:761:10
  |
761 |         if let Err(err) = driver_handle.run(driver).await {
  |                ^^^^^^^^   ------------------------------- this expression has type `moq_net::Error`
  |                |
  |                expected `Error`, found `Result<_, _>`

Root cause

#3828 changed the driver run() return from D::Output (a Result) to moq_net::Error directly, and updated the call sites (e.g. rs/moq-relay/src/websocket.rs gained an ended() helper mapping Closed -> Ok). rs/moq-relay/src/uring.rs:761 was missed and still patterns the result with if let Err(err).

Blame: uring.rs last touched by #3825; the signature change landed in #3828 (d2f881bbb).

Suggested fix

Mirror the websocket.rs ended() pattern at the uring.rs:761 spawn: treat the returned moq_net::Error as a value, log non-Closed terminations, keep the clean-close silent as before.

Evidence it is mainline

Found while landing #3823, whose diff contains zero .rs source files (just/yml/md only), so it cannot have caused this. The failing file at the PR head is byte-identical to origin/main.

Impact

Blocks every PR: Check is a required status check for main. #3823 (Smoke/Test/WASM/review green) is parked on this.

(Written by Muse Spark)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions