You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Split out of a review finding on #2867 (CodeRabbit flagged the stale pin; the divergence below is what makes it worth its own issue).
The two versions
cpp/obs/buildspec.json pins obs-studio 31.1.1. That's what the obs-deps download gives a macOS or Windows build, so it's the libobs the released plugin binaries link against.
nixpkgs currently carries obs-studio 32.1.2, which is what a Linux just obs build and the new obs.yml gate link against.
So the Linux compile gate and the shipped macOS/Windows binaries are a major OBS release apart. Nothing has broken yet, but that gap is exactly where a libobs API change gets through CI and shows up only in a release build, on the platforms with no compile gate at all.
What to do
Bump cpp/obs/buildspec.json to the current stable (32.2.2 at time of writing) and move libobs-headers in flake.nix in the same commit. Needs:
new hashes for the obs-studio, prebuilt obs-deps and Qt6 archives (macOS + Windows entries), and the nix fetchzip hash;
a check that libobs/obsconfig.h.in and frontend/api/obs-frontend-api.h are still where libobs-headers expects them;
a real just obs build on macOS, since that's the platform the release actually ships and the one PR CI never compiles.
just obs check will fail until both pins move together, which is the intended tripwire rather than an obstacle.
Split out of a review finding on #2867 (CodeRabbit flagged the stale pin; the divergence below is what makes it worth its own issue).
The two versions
cpp/obs/buildspec.jsonpins obs-studio 31.1.1. That's what the obs-deps download gives a macOS or Windows build, so it's the libobs the released plugin binaries link against.just obs buildand the newobs.ymlgate link against.flake.nix'slibobs-headersalso pins 31.1.1, matching buildspec.json (feat(obs): compile the plugin in CI, and type-check it without obs-deps #2867 added a guard injust obs checkthat fails if those two drift).So the Linux compile gate and the shipped macOS/Windows binaries are a major OBS release apart. Nothing has broken yet, but that gap is exactly where a libobs API change gets through CI and shows up only in a release build, on the platforms with no compile gate at all.
What to do
Bump
cpp/obs/buildspec.jsonto the current stable (32.2.2 at time of writing) and movelibobs-headersinflake.nixin the same commit. Needs:fetchziphash;libobs/obsconfig.h.inandfrontend/api/obs-frontend-api.hare still wherelibobs-headersexpects them;just obs buildon macOS, since that's the platform the release actually ships and the one PR CI never compiles.just obs checkwill fail until both pins move together, which is the intended tripwire rather than an obstacle.(written by Opus 5)