Skip to content

Fix the demo's CLI snippets and document the try flow - #151

Merged
kixelated merged 2 commits into
mainfrom
claude/try-project
Sep 28, 2026
Merged

kixelated merged 2 commits into
mainfrom
claude/try-project

Conversation

@kixelated

@kixelated kixelated commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • The terminal snippets on /demo fail with the current moq-cli (0.12.x). --client-connect is now --connect. ffmpeg's frag_every_frame repeats a tfdt when it interleaves audio and video, and moq import fmp4 now refuses that, so the snippets use -frag_duration 1000 like the upstream demo recipes.
  • CLAUDE.md described the pre-feat: use private try broadcasts and require explicit projects #136 scheme (bare moq.pub/ invents an anon name, moq.pub never links to moq.watch). It now describes the private try flow and the rule that a watch link never carries ?jwt=.

Validation

Ran the edited snippets with moq 0.12.1. The test-pattern publish into anon on cdn.moq.wtf and its export returned media, and so did the demo/bbb.hang export on cdn.moq.pro. just check and just test pass.

Staging check of #136

#136 was merged but never deployed. I deployed main to staging (new.moq.dev, new.moq.pub, new.moq.watch, against api.moq.wtf):

  • new.moq.dev/publish and bare new.moq.pub/ both mint a try broadcast. The share link is new.moq.watch/try/<id>.hang with no token, and the moq.pub link is no-referrer.
  • Publishing into those credentials (synthetic media via moq import, since the test browser had no camera) plays at the tokenless share link and at new.moq.dev/watch?project=try&name=<id>. Both mint a subscribe-only token.
  • The relay refuses the same path with no token (unauthorized), and a watch token for another try broadcast receives nothing.
  • An invalid try name and a missing ?project= show an error with no fallback.

Live rollout (manual, maintainer)

Merging does not deploy: the only workflow is the PR check, and live ships from just deploy live. Live still runs the pre-#136 build (bare moq.pub/ redirects to an invented /anon name). After just deploy live:

  • Bare moq.pub/ lands on /try/<id>.hang?jwt=..., and its "Watch link" is moq.watch/try/<id>.hang with no jwt.
  • moq.dev/publish shows a try broadcast whose copied URL has no jwt.
  • Publish from each (camera, or moq import fmp4 with the page's minted publish token), then open the share link in a private window: it plays.
  • moq --connect https://cdn.moq.pro/try --broadcast <id>.hang export fmp4 with no token is refused unauthorized.
  • moq.dev/watch?project=try&name=<id>.hang plays, and moq.dev/watch?name=<id>.hang without project shows an error.
  • moq.watch/demo/bbb.hang still plays tokenless.

(written by Claude Opus 5.5)

🤖 Generated with Claude Code

moq-cli 0.12 renamed --client-connect to --connect and rejects ffmpeg's
frag_every_frame output, which repeats a tfdt when audio and video
interleave. Use -frag_duration like the upstream demo recipes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 23 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c0b283d1-43bf-4088-bada-278272c4efcc

📥 Commits

Reviewing files that changed from the base of the PR and between 5c1729f and 905ec70.

📒 Files selected for processing (2)
  • CLAUDE.md
  • src/pages/demo.mdx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T01:39:38.041637Z 905ec70 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

A bare moq.pub/ now mints a try broadcast and links to moq.watch without
the publish token; the old text said it invents an anon name and never links.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Update the demo's CLI snippets for moq-cli 0.12 Fix the demo's CLI snippets and document the try flow Sep 25, 2026
@kixelated
kixelated merged commit e709d25 into main Sep 28, 2026
2 checks passed
@kixelated
kixelated deleted the claude/try-project branch September 28, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant