Fix the demo's CLI snippets and document the try flow - #151
Conversation
moq-cli 0.12 renamed --client-connect to --connect and rejects ffmpeg's frag_every_frame output, which repeats a tfdt when audio and video interleave. Use -frag_duration like the upstream demo recipes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 23 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
A bare moq.pub/ now mints a try broadcast and links to moq.watch without the publish token; the old text said it invents an anon name and never links. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
/demofail with the currentmoq-cli(0.12.x).--client-connectis now--connect. ffmpeg'sfrag_every_framerepeats atfdtwhen it interleaves audio and video, andmoq import fmp4now refuses that, so the snippets use-frag_duration 1000like the upstream demo recipes.CLAUDE.mddescribed the pre-feat: use private try broadcasts and require explicit projects #136 scheme (baremoq.pub/invents ananonname, moq.pub never links to moq.watch). It now describes the privatetryflow and the rule that a watch link never carries?jwt=.Validation
Ran the edited snippets with
moq0.12.1. The test-pattern publish intoanononcdn.moq.wtfand its export returned media, and so did thedemo/bbb.hangexport oncdn.moq.pro.just checkandjust testpass.Staging check of #136
#136 was merged but never deployed. I deployed
mainto staging (new.moq.dev,new.moq.pub,new.moq.watch, againstapi.moq.wtf):new.moq.dev/publishand barenew.moq.pub/both mint atrybroadcast. The share link isnew.moq.watch/try/<id>.hangwith no token, and the moq.pub link isno-referrer.moq import, since the test browser had no camera) plays at the tokenless share link and atnew.moq.dev/watch?project=try&name=<id>. Both mint a subscribe-only token.unauthorized), and a watch token for anothertrybroadcast receives nothing.tryname and a missing?project=show an error with no fallback.Live rollout (manual, maintainer)
Merging does not deploy: the only workflow is the PR check, and live ships from
just deploy live. Live still runs the pre-#136 build (baremoq.pub/redirects to an invented/anonname). Afterjust deploy live:moq.pub/lands on/try/<id>.hang?jwt=..., and its "Watch link" ismoq.watch/try/<id>.hangwith nojwt.moq.dev/publishshows atrybroadcast whose copied URL has nojwt.moq import fmp4with the page's minted publish token), then open the share link in a private window: it plays.moq --connect https://cdn.moq.pro/try --broadcast <id>.hang export fmp4with no token is refusedunauthorized.moq.dev/watch?project=try&name=<id>.hangplays, andmoq.dev/watch?name=<id>.hangwithoutprojectshows an error.moq.watch/demo/bbb.hangstill plays tokenless.(written by Claude Opus 5.5)
🤖 Generated with Claude Code