Repository navigation
refactor: reorganize code structure and improve request handling - #12
Merged
Merged
Conversation
Contributor
PR Reviewer Guide 🔍(Review updated until commit af66d2c)Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
|
Contributor
|
Persistent review updated to latest commit af66d2c |
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Type
Enhancement, Tests
Description
Adopt
flagruncommand execution framework.Extract HTTP request handling into
request.go.Add client-wide timeout and statistical calculations.
Add comprehensive request and metrics tests.
Diagram Walkthrough
File Walkthrough
main.go
Refactor command execution and RTT metric collectionmain.go
flagrun.Optcommand type.statsand write to a supplied writer.request.go
Extract and harden HTTP request timingrequest.go
Optmethod.doRequest.errors.Is.main_test.go
Add comprehensive HTTP statistics command testsmain_test.go
settings.
getStatsbenchmark coverage.request_test.go
Test HTTP request creation and timingrequest_test.go
testutil_test.go
Add reusable HTTP metrics test utilitiestestutil_test.go
testingT.go.mod
Add command statistics and test dependenciesgo.mod
flagrunfor command parsing and execution.statsfor RTT aggregate calculations.testifyand its indirect test dependencies.golang.org/x/sysdependency.