Skip to content

Cover candidate budgets and combine real legacy/current coverage - #68

Merged
dblock merged 1 commit into
mongoid:masterfrom
dblock:dblock/coverage
Oct 18, 2026
Merged

dblock merged 1 commit into
mongoid:masterfrom
dblock:dblock/coverage

Conversation

@dblock

@dblock dblock commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Default-branch baseline91.05%. Add a real search with candidate budget1 and two matching documents, exercising both initial budget truncation and limited later-ngram candidates, plus standalone version loading. Collect coverage from the actual Mongoid3.1 and modern supported integration jobs, including legacy index hooks and persistence APIs; combine Coveralls reports after the whole test matrix succeeds. Ruby-compatible SimpleCov0.16 for old Rubies,0.22 for modern.

160 examples and local rake pass. Modern-only coverage93.25% (290/311); nearly all remaining lines are old-driver paths which must be measured in their real matrix. Two DiacriticsFu fallback lines appear unreachable because UnicodeUtils is an unconditional dependency; do not fabricate a provider or hide it merely to change a metric.

No production changes or source exclusions. Independent of unmerged highlightingPR67.

Accepted CI coverage: 99.04% (308/311 relevant lines), Coveralls build 82425302.

Prepared by an AI on behalf of @dblock.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Danger Report

No issues found.

View run

Exercise both candidate truncation branches and standalone version loading. Combine actual Mongoid3.1 and current matrix reports so legacy index hooks and persistence calls are measured without exclusions or mocked version branches.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dblock
dblock merged commit 65e871b into mongoid:master Oct 18, 2026
14 checks passed
@dblock
dblock deleted the dblock/coverage branch October 18, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant