Repository navigation
Correct bounded ngram query sampling - #55
Merged
Merged
Conversation
dblock
force-pushed
the
dblock/ngram-sampling
branch
from
October 17, 2026 02:49
192f7b3 to
4c267b9
Compare
This was referenced Oct 17, 2026
dblock
force-pushed
the
dblock/ngram-sampling
branch
2 times, most recently
from
October 17, 2026 03:30
eb90332 to
0a8df79
Compare
Danger ReportNo issues found. |
dblock
force-pushed
the
dblock/ngram-sampling
branch
from
October 17, 2026 03:35
0a8df79 to
60e097e
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
dblock/ngram-sampling
branch
from
October 17, 2026 03:37
60e097e to
07a6ee1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the stride calculation with an exact bounded sample across the query, including both endpoints when taking multiple samples. The example in #18 now produces abc, efg, ijk. Cover every length 0–26 and bound 1–12, one-sample behavior, unbounded indexing, and independent full-word/prefix bonuses. Reject invalid limits at declaration time. Document possible ranking changes and that no reindex is required.
Fixes #18. Depends on #51.
Prepared by an AI on behalf of @dblock.