Skip to content

Preserve localized slug history across fallbacks - #285

Open
dblock wants to merge 1 commit into
masterfrom
dblock/localized-fallback-slugs
Open

dblock wants to merge 1 commit into
masterfrom
dblock/localized-fallback-slugs

Conversation

@dblock

@dblock dblock commented Oct 18, 2026

Copy link
Copy Markdown
Collaborator

Fixes #184.

Reproduces the reported corruption with real I18n fallbacks: assigning the same title in Dutch removes the English slug. The localized reader can return the fallback locale array, so deleting the new slug from that reader mutates another locale.

Avoid that deletion for localized fields. Copy and deduplicate only the explicit target-locale history when appending, retaining current-slug ordering and independent histories. Includes persisted regressions for equal translated titles and repeated locale-specific edits, with fallback configuration restored after each example.

Prepared by an AI on behalf of @dblock.

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Danger Report

No issues found.

View run

@coveralls

coveralls commented Oct 18, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 39140579685

Coverage increased (+0.01%) to 96.785%

Details

  • Coverage increased (+0.01%) from the base build.
  • Patch coverage: 3 of 3 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 311
Covered Lines: 301
Line Coverage: 96.78%
Coverage Strength: 307.99 hits per line

💛 - Coveralls

Fixes #184. Avoid mutating a fallback locale array and deduplicate only the explicitly selected locale history.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dblock
dblock force-pushed the dblock/localized-fallback-slugs branch from b33ec42 to 20c6bd1 Compare October 18, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default Locale Slug is emptied, when another Locale has the same value

2 participants