Repository navigation
Conversation
`__find_args__` is deprecated in Mongoid 9.x and will be removed in Mongoid 10.0 It's functionally equivalent to `Array#flatten` This fixes the deprecation warning: DEPRECATION WARNING: find_args is deprecated and will be removed from Mongoid 10.0 Co-authored-by: samiFakhfakhScalingo <sami.fakhfakh@scalingo.com>
Danger ReportNo issues found. |
aurelien-reeves-scalingo
force-pushed
the
fix/remove_deprecated_find_args
branch
from
May 22, 2026 13:25
7154634 to
3916ee1
Compare
This was referenced May 22, 2026
Collaborator
|
@aurelien-reeves-scalingo take a look at #275, anything we need from there? |
Contributor
Author
|
Indeed, multi_arged? is deprecated too But I don't know if changes from #275 are relevant as they broke the CI. The author mentioned that the failures were "unrelated to its PR". To begin with, trying to re-run the CI on #275 to see if more recent versions of Mongoid have fixed the failures may be a first step. WDYT? |
Collaborator
|
@aurelien-reeves-scalingo just extract/rebase this PR into a new one? |
Contributor
Author
|
Yes, we can give it a try |
Contributor
Author
|
Here it is: #280 |
Contributor
Author
|
@dblock is it planned to release recent changes to the gem? |
Collaborator
|
I released 7.1.0. Sorry for the delay. |
Contributor
Author
|
Great, thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__find_args__is deprecated in Mongoid 9.x and will be removed in Mongoid 10.0 It's functionally equivalent toArray#flattenThis fixes the deprecation warning: DEPRECATION WARNING: find_args is deprecated and will be removed from Mongoid 10.0