Repository navigation
Migrate Danger to danger-pr-comment workflows - #84
Merged
Merged
Conversation
dblock
force-pushed
the
dblock/danger-pr-comment
branch
3 times, most recently
from
October 14, 2026 22:33
c5d8cd4 to
7190505
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
dblock/danger-pr-comment
branch
from
October 14, 2026 22:36
7190505 to
52d836b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow mongoid/mongoid-slug#277: import danger-pr-comment, validate changelog entries, and separate read-only PR checks from report-based comment publishing. Replace the embedded-token workflow with GitHub token authentication and the pinned reusable comment workflow.
Keep Danger in the existing isolated Gemfile.danger so checking PRs does not install Rails/Mongoid or depend on the legacy test matrix. Remove mongoid-danger from both the Danger bundle and gemspec development dependencies; use danger-changelog 0.9.0 for bot attribution support. Ruby 3.4 runs only the Danger job; application compatibility is unchanged.
Validation: isolated bundle installs, changed Ruby files pass syntax checks, workflow YAML parses, and git diff --check passes. Existing application CI is left unchanged.
Prepared by AI on behalf of @dblock.
CI follow-up: replace default Bundler 1 with 2.4.22 for modern Rails bundles, explicitly require Logger before Rails 6, retain Minitest 5 for the existing assertion helper, replace the MongoDB action with health-checked official service containers, and add Ruby 3.4/4.0 with MongoDB 7/8 and Mongoid 9. The local Mongoid 9 suite passes: 18 tests, 57 assertions; RuboCop also passes.