RUBY-3872 Fix put_double TypeError message regex for Ruby head#373
Open
comandeo-mongo wants to merge 1 commit into
Open
RUBY-3872 Fix put_double TypeError message regex for Ruby head#373comandeo-mongo wants to merge 1 commit into
comandeo-mongo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Update the
put_doubleTypeError message regex inspec/bson/byte_buffer_write_spec.rbto accept both the old and new Ruby TypeError wording.Ruby head changed the message from:
no implicit conversion to float from string(Ruby ≤ 3.4)to:
no implicit conversion of String into Float(Ruby head)The regex now covers both MRI forms plus the existing JRuby
ClassCastExceptionform. No production code changes.Files changed
spec/bson/byte_buffer_write_spec.rb— regex on line 511 extendedTest plan
bundle exec rspec spec/bson/byte_buffer_write_spec.rb— 87 examples, 0 failuresJira: https://jira.mongodb.org/browse/RUBY-3872