Skip to content

chore: unpin devtools-shared action - #974

Merged
nbbeeken merged 2 commits into
mainfrom
gha-unpin
Nov 20, 2026
Merged

nbbeeken merged 2 commits into
mainfrom
gha-unpin

Conversation

@nbbeeken

Copy link
Copy Markdown
Collaborator

Description

This action is defined in this repo, we don't need to pin it.

Added a timeout to the tests so instead of "cancel" we get "failure"

Checklist

@nbbeeken
nbbeeken requested review from a team as code owners November 19, 2026 20:06
@nbbeeken
nbbeeken requested review from dudaschar and a balanced review from Copilot November 19, 2026 20:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the workflow bot-token reference and test-timeout changes.

No open issues 🎉

What changed in this PR

This PR updates the repository’s automation to use its own bot-token action from main and adjusts test timeouts so stalled tests can time out before the overall job.

Changes:

  • Replace the pinned setup-bot-token commit with @main in three workflows.
  • Increase the check-and-test job timeout from 45 to 60 minutes.
  • Add a 35-minute timeout to the Run Tests step.
File Description
.github/​workflows/​update-cidrs.yaml Use the bot-token action from main for CIDR updates.
.github/​workflows/​publish-packages.yaml Use the bot-token action from main for publishing.
.github/​workflows/​check-test.yaml Increase the job timeout and add a test-step timeout.
.github/​workflows/​bump-packages.yaml Use the bot-token action from main for package bumps.

Review effort: Balanced

@nbbeeken
nbbeeken enabled auto-merge (squash) November 19, 2026 21:26
@nbbeeken
nbbeeken merged commit 1babc14 into main Nov 20, 2026
20 checks passed
@nbbeeken
nbbeeken deleted the gha-unpin branch November 20, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants