Repository navigation
feat: folders in connection import/export COMPASS-11310 - #8718
Draft
paula-stacho wants to merge 8 commits into
Draft
paula-stacho wants to merge 8 commits into
paula-stacho wants to merge 8 commits into
Conversation
paula-stacho
requested review from
KareBearIsBoss8
and
a balanced review from Copilot
November 20, 2026 18:07
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Folder imports use case-sensitive matching, allowing work and Work to coexist and split connections despite the UI’s case-insensitive uniqueness rules.
1 open issue
What changed in this PR
Adds folder support to Compass connection import/export, connecting folder storage with grouped selection in the import and export dialogs.
Changes:
- Serializes folder assignments and merges imported folders into local storage.
- Adds reusable grouped selection controls, gated by the connection-folders preference.
- Adds storage, compatibility, and UI tests.
| File | Description |
|---|---|
packages/connection-storage/src/provider.ts |
Exposes folder import types and parsing. |
packages/connection-storage/src/import-export-folders.ts |
Adds folder filtering, validation, and merging. |
packages/connection-storage/src/import-export-folders.spec.ts |
Tests folder merging and invalid input. |
packages/connection-storage/src/import-export-connection.ts |
Includes folder metadata in exports. |
packages/connection-storage/src/import-export-connection.spec.ts |
Tests folder exports and format compatibility. |
packages/connection-storage/src/compass-main-connection-storage.ts |
Integrates folder persistence with import/export. |
packages/connection-storage/src/compass-main-connection-storage.spec.ts |
Tests folder round trips and failure handling. |
packages/connection-storage/package.json |
Adds the validation dependency. |
packages/compass/src/main/application.ts |
Wires preference-controlled folder storage. |
packages/compass-connections/src/stores/connections-store-redux.ts |
Reloads folders after importing connections. |
packages/compass-connection-import-export/src/hooks/use-import-connections.ts |
Loads folder metadata for import previews. |
packages/compass-connection-import-export/src/components/import-modal.tsx |
Displays imported connections by folder. |
packages/compass-connection-import-export/src/components/import-modal.spec.tsx |
Tests grouped and uncategorized imports. |
packages/compass-connection-import-export/src/components/group-by-folder.tsx |
Shares folder grouping and sorting logic. |
packages/compass-connection-import-export/src/components/export-modal.tsx |
Displays export selections by folder. |
packages/compass-connection-import-export/src/components/export-modal.spec.tsx |
Tests grouping order and disabled-feature behavior. |
packages/compass-components/src/index.ts |
Exposes grouped selection components and types. |
packages/compass-components/src/components/select-list.tsx |
Exposes shared selection styles and types. |
packages/compass-components/src/components/select-list-with-groups.tsx |
Adds grouped selection controls and counts. |
packages/compass-components/src/components/select-list-with-groups.spec.tsx |
Tests selection states and interactions. |
package-lock.json |
Records the validation dependency. |
Review effort: Balanced
| if (!importedFolder) { | ||
| continue; | ||
| } | ||
| let folder = folders.find(({ name }) => name === importedFolder.name); |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes