Skip to content

fix: flexible icon color - #8717

Merged
paula-stacho merged 1 commit into
mainfrom
icon-color
Nov 20, 2026
Merged

paula-stacho merged 1 commit into
mainfrom
icon-color

Conversation

@paula-stacho

Copy link
Copy Markdown
Collaborator

Description

I noticed one of the newly added icons has the wrong color on the menu, because the menu is dark even though the global theme is light.

Using the color of the context makes things simpler - the icon now takes on dark/light depending on the surrounding text. I updated also some other icons and removed one that isn't used anymore.

Screenshots

Notice the same icon is on the sidebar and on the menu

Before

Screenshot 2026-11-20 at 16 52 11

After

Screenshot 2026-11-20 at 16 30 17

@paula-stacho
paula-stacho requested a review from a team as a code owner November 20, 2026 15:53
@paula-stacho
paula-stacho requested review from esvm and a balanced review from Copilot November 20, 2026 15:53
@github-actions github-actions Bot added the fix label Nov 20, 2026
@paula-stacho paula-stacho added feature flagged PRs labeled with this label will not be included in the release notes of the next release no release notes Fix or feature not for release notes and removed feature flagged PRs labeled with this label will not be included in the release notes of the next release labels Nov 20, 2026
@paula-stacho paula-stacho added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Nov 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the shared-icon color inheritance changes.

No open issues 🎉

What changed in this PR

This PR makes shared icons inherit surrounding text color, fixing their appearance in dark menus when the global theme is light. The changes simplify color handling while preserving explicit color overrides.

Changes:

  • Default server and folder icons to currentColor instead of global-theme colors.
  • Add an explicit color override to FolderPlusIcon.
  • Remove the unused FavoriteIcon component and export.
File Description
packages/​compass-components/​src/​index.ts Removes the FavoriteIcon export.
packages/​compass-components/​src/​components/​icons/​server-icon.tsx Defaults stroke color to surrounding text color.
packages/​compass-components/​src/​components/​icons/​folder-plus-icon.tsx Inherits text color and supports a color override.
packages/​compass-components/​src/​components/​icons/​folder-icon.tsx Defaults stroke color to surrounding text color.
packages/​compass-components/​src/​components/​icons/​favorite-icon.tsx Deletes the unused icon component.

Review effort: Balanced

@esvm esvm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paula-stacho
paula-stacho merged commit f39797b into main Nov 20, 2026
57 of 65 checks passed
@paula-stacho
paula-stacho deleted the icon-color branch November 20, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants