Repository navigation
fix(compass-assistant): resend after auto-run tool calls complete COMPASS-11386 - #8715
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change restoring follow-up responses after completed tool calls.
No open issues 🎉
What changed in this PR
Restores Compass Assistant’s follow-up responses after tools run without approval, addressing the gap exposed by #8705. The change is narrowly scoped and includes focused regression coverage.
Changes:
- Extends automatic resending to completed tool calls while retaining approval-response handling.
- Adds tests for tool-result follow-ups and stopping after plain-text responses.
| File | Description |
|---|---|
| packages/compass-assistant/src/compass-assistant-provider.tsx | Enables automatic follow-up requests after completed tool calls. |
| packages/compass-assistant/src/compass-assistant-provider.spec.tsx | Adds regression tests for automatic follow-ups and plain-text completion. |
Review effort: Balanced
kmruiz
approved these changes
Nov 19, 2026
LuciaHarcekova
approved these changes
Nov 19, 2026
esvm
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
createDefaultChatonly setsendAutomaticallyWhentolastAssistantMessageIsCompleteWithApprovalResponses, so the chat only sen again after the user approved a tool call.Tools that don't need approval run inside the request that called them, and the transport is single-step (
streamTexthas nostopWhen). Once such a tool finished, nothing sent again and the model never saw the result. The user gotthe raw tool output and no text reply.
sendAutomaticallyWhennow also returns true whenlastAssistantMessageIsCompleteWithToolCallsis, so the model responds to the tool result.The approval flow shouldn't change. After the follow-up text, the last step has no tool calls, and denied tools don't count as complete.
Checklist
Motivation and Context
#8705 removed
needsApprovalfrom the Compass tools to match the mongodb-mcp-server defaults. That exposed this gap: with no approval step, nothing triggered the follow-up request.Open Questions
Dependents
Types of changes