Repository navigation
fix(deps): bump @mongodb-js/shell-bson-parser to ^2.2.3 COMPASS-11375 - #8696
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the _bsontype serialization update.
No open issues 🎉
What changed in this PR
This PR brings the upstream _bsontype serialization fix into Compass. The dependency changes are consistent across the affected packages and lockfile, and the regression test checks user-visible pipeline rendering.
Changes:
- Updates
@mongodb-js/shell-bson-parserto^2.2.3across 15 packages. - Locks the resolved parser version to
2.2.3. - Adds coverage for rendering ordinary document data containing an
_bsontypefield.
| File | Description |
|---|---|
| packages/mock-data-generator/package.json | Adopts the parser fix for mock data generation. |
| packages/hadron-document/package.json | Adopts the parser fix for document handling. |
| packages/explain-plan-helper/package.json | Adopts the parser fix for explain plans. |
| packages/databases-collections/package.json | Adopts the parser fix for database and collection features. |
| packages/connection-form/package.json | Adopts the parser fix for connection forms. |
| packages/compass-schema-validation/package.json | Adopts the parser fix for schema validation. |
| packages/compass-query-bar/package.json | Adopts the parser fix for query editing. |
| packages/compass-indexes/package.json | Adopts the parser fix for index features. |
| packages/compass-import-export/package.json | Adopts the parser fix for import and export. |
| packages/compass-generative-ai/package.json | Adopts the parser fix for generative AI features. |
| packages/compass-export-to-language/package.json | Adopts the parser fix for language export. |
| packages/compass-editor/package.json | Adopts the parser fix for shared editors. |
| packages/compass-crud/package.json | Adopts the parser fix for document operations. |
| packages/compass-components/package.json | Adopts the parser fix for shared components. |
| packages/compass-aggregations/src/components/pipeline-builder-workspace/pipeline-builder-ui-workspace/index.spec.tsx | Tests pipeline rendering with an ordinary _bsontype field. |
| packages/compass-aggregations/package.json | Adopts the parser fix for aggregation pipelines. |
| package-lock.json | Synchronizes dependency ranges and pins parser 2.2.3. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
2.2.3 fixes
toJSStringso that a plain object with its own_bsontypefield for example, a document read from the server) is serialized as a regular object instead of being handed to the BSON serializers. Real BSON values are serialized as before. See mongodb-js/devtools-shared#970.Adds a test that renders a pipeline containing a field named
_bsontypeand checks it is shown as regular document data.Checklist
Motivation and Context
Open Questions
Dependents
Types of changes