Skip to content

fix(deps): bump @mongodb-js/shell-bson-parser to ^2.2.3 COMPASS-11375 - #8696

Merged
dudaschar merged 3 commits into
mainfrom
COMPASS-11375
Nov 13, 2026
Merged

dudaschar merged 3 commits into
mainfrom
COMPASS-11375

Conversation

@dudaschar

Copy link
Copy Markdown
Collaborator

Description

2.2.3 fixes toJSString so that a plain object with its own _bsontype field for example, a document read from the server) is serialized as a regular object instead of being handed to the BSON serializers. Real BSON values are serialized as before. See mongodb-js/devtools-shared#970.

Adds a test that renders a pipeline containing a field named _bsontype and checks it is shown as regular document data.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • If this change could impact the load on the MongoDB cluster, please describe the expected and worst case impact
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@dudaschar
dudaschar requested a review from a team as a code owner November 13, 2026 13:05
@dudaschar
dudaschar requested review from Anemy and a balanced review from Copilot November 13, 2026 13:05
@dudaschar dudaschar self-assigned this Nov 13, 2026
@github-actions github-actions Bot added the fix label Nov 13, 2026
@dudaschar dudaschar changed the title fix(deps): bump @mongodb-js/shell-bson-parser to ^2.2.3 fix(deps): bump @mongodb-js/shell-bson-parser to ^2.2.3 COMPASS-11375 Nov 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the _bsontype serialization update.

No open issues 🎉

What changed in this PR

This PR brings the upstream _bsontype serialization fix into Compass. The dependency changes are consistent across the affected packages and lockfile, and the regression test checks user-visible pipeline rendering.

Changes:

  • Updates @mongodb-js/shell-bson-parser to ^2.2.3 across 15 packages.
  • Locks the resolved parser version to 2.2.3.
  • Adds coverage for rendering ordinary document data containing an _bsontype field.
File Description
packages/​mock-data-generator/​package.json Adopts the parser fix for mock data generation.
packages/​hadron-document/​package.json Adopts the parser fix for document handling.
packages/​explain-plan-helper/​package.json Adopts the parser fix for explain plans.
packages/​databases-collections/​package.json Adopts the parser fix for database and collection features.
packages/​connection-form/​package.json Adopts the parser fix for connection forms.
packages/​compass-schema-validation/​package.json Adopts the parser fix for schema validation.
packages/​compass-query-bar/​package.json Adopts the parser fix for query editing.
packages/​compass-indexes/​package.json Adopts the parser fix for index features.
packages/​compass-import-export/​package.json Adopts the parser fix for import and export.
packages/​compass-generative-ai/​package.json Adopts the parser fix for generative AI features.
packages/​compass-export-to-language/​package.json Adopts the parser fix for language export.
packages/​compass-editor/​package.json Adopts the parser fix for shared editors.
packages/​compass-crud/​package.json Adopts the parser fix for document operations.
packages/​compass-components/​package.json Adopts the parser fix for shared components.
packages/​compass-aggregations/​src/​components/​pipeline-builder-workspace/​pipeline-builder-ui-workspace/​index.spec.tsx Tests pipeline rendering with an ordinary _bsontype field.
packages/​compass-aggregations/​package.json Adopts the parser fix for aggregation pipelines.
package-lock.json Synchronizes dependency ranges and pins parser 2.2.3.

Review effort: Balanced

@esvm esvm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dudaschar
dudaschar merged commit 1244095 into main Nov 13, 2026
57 checks passed
@dudaschar
dudaschar deleted the COMPASS-11375 branch November 13, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants