Skip to content

feat: create AI Assistant utility COMPASS-11269 - #8629

Closed
esvm wants to merge 19 commits into
mainfrom
COMPASS-11269
Closed

esvm wants to merge 19 commits into
mainfrom
COMPASS-11269

Conversation

@esvm

@esvm esvm commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • If this change could impact the load on the MongoDB cluster, please describe the expected and worst case impact
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@esvm esvm self-assigned this Oct 27, 2026
Copilot AI balanced review requested due to automatic review settings October 27, 2026 14:23
@github-actions github-actions Bot added the feat label Oct 27, 2026

This comment was marked as outdated.

@esvm esvm changed the title feat: create utility feat: create AI Assistant utility COMPASS-11269 Oct 27, 2026
@esvm
esvm requested a balanced review from Copilot October 27, 2026 15:32

This comment was marked as outdated.

@esvm
esvm requested a balanced review from Copilot October 28, 2026 12:18

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this class out of tools-controller but it has the same content

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this class out of tools-controller but it has the same content

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the connect params now are sent to a different process, we might lose their types. So in order to preserve it, I'm encoding/decoding using bson

This comment was marked as outdated.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the type definitions for the data sent through the utility rpc

@esvm
esvm requested a balanced review from Copilot October 28, 2026 12:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Remote transport closure can leave tool calls hanging and prevent recovery, while Electron-only startup leaves database tools unavailable in Compass Web.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

@nbbeeken
nbbeeken self-requested a review October 28, 2026 16:09
@esvm

esvm commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

splitting this into 2:
#8636
#8637

@esvm esvm closed this Oct 28, 2026
@esvm
esvm deleted the COMPASS-11269 branch October 28, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants