Repository navigation
Conversation
esvm
commented
Oct 28, 2026
Collaborator
Author
There was a problem hiding this comment.
I moved this class out of tools-controller but it has the same content
esvm
commented
Oct 28, 2026
Collaborator
Author
There was a problem hiding this comment.
I moved this class out of tools-controller but it has the same content
esvm
commented
Oct 28, 2026
Collaborator
Author
There was a problem hiding this comment.
because the connect params now are sent to a different process, we might lose their types. So in order to preserve it, I'm encoding/decoding using bson
esvm
commented
Oct 28, 2026
Collaborator
Author
There was a problem hiding this comment.
that's the type definitions for the data sent through the utility rpc
nbbeeken
self-requested a review
October 28, 2026 16:09
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes