fix(l10n): apply appearance name localization in MainWindow - #146
Open
boombertz wants to merge 1 commit into
Open
fix(l10n): apply appearance name localization in MainWindow#146boombertz wants to merge 1 commit into
boombertz wants to merge 1 commit into
Conversation
The appearance name (System/Light/Dark) was rendered via Text(String) and Label(String, systemImage:), which use the non-localizing initializers. As a result the existing "System"/"Light"/"Dark" translations were never applied and the labels always showed English. Wrap the values in LocalizedStringKey (matching AppearancePill) at the menu item, the sidebar value, and the accessibility value so they localize correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The appearance name (System/Light/Dark) was rendered via Text(String) and Label(String, systemImage:), which use the non-localizing initializers. As a result the existing "System"/"Light"/"Dark" translations were never applied and the labels always showed English.
Wrap the values in LocalizedStringKey (matching AppearancePill) at the menu item, the sidebar value, and the accessibility value so they localize correctly.