Add Russian and Ukrainian localizations - #130
Open
TinyFrontier wants to merge 3 commits into
Open
Conversation
TinyFrontier
force-pushed
the
feature/russian-ukrainian-localization
branch
from
July 19, 2026 08:40
e72d7f9 to
017b6c1
Compare
TinyFrontier
marked this pull request as ready for review
July 19, 2026 08:40
|
Following the CONTRIBUTING.md and for a better follow up of your changes, could you split the commit beyond the localizations? There are more than Russian and Ukrainian and translations in your PR. |
TinyFrontier
force-pushed
the
feature/russian-ukrainian-localization
branch
from
July 30, 2026 09:51
017b6c1 to
5737663
Compare
Author
|
@boombertz Thanks for the feedback. I rebased the branch onto the latest main, removed the unrelated copy/error behavior changes, and split the work into three focused commits: dynamic UI localization, Russian and Ukrainian resources, and localization tests. The Universal Release build and all 10 tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
PureMac did not previously support Russian or Ukrainian, and several dynamically constructed strings bypassed the localization lookup even when translation keys existed.
User impact
Russian- and Ukrainian-speaking users can select their language in Settings and use the complete GUI, including onboarding, Full Disk Access guidance, cleanup flows, permission prompts, and Finder services. The selected language still applies after relaunch, matching the existing language-switching behavior.
Validation
arm64andx86_64.strings, plist, entitlement, and project files withplutil