Skip to content

Allow approval after a corrected submission passes its latest review - #44

Merged
maoawa merged 1 commit into
mainfrom
fix/latest-review-checks
Sep 23, 2026
Merged

maoawa merged 1 commit into
mainfrom
fix/latest-review-checks

Conversation

@maoawa

@maoawa maoawa commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Editing a PR description creates another Actions check suite on the same commit. The approval service previously required every historical suite to pass, so an original missing-description failure blocked approval even after a successful recheck.

Resolve repeated Actions job names to their workflow identity and evaluate the newest run for that workflow/event/job. Keep unrelated workflows and apps as independent blockers, and reject incomplete or inconsistent check data. Approval errors now identify validation failures, mergeability, or the specific pending/failed check.

Validation: 35 Worker tests and the deployment dry run pass. Five regression tests cover superseded failures, new failures/pending runs, workflow/event/app isolation, mismatched metadata, and truncation. A read-only check using the production App confirms PR #42 passes validation and check readiness and is mergeable; no review or merge was performed.

@github-actions

Copy link
Copy Markdown

❌ Submission needs attention

❌ 申请需要修改或人工处理

  • docs/review-automation.md: only added/modified records/*.json files qualify; maintenance, deletions, and renames need manual review.
    docs/review-automation.md:自动审核仅支持新增或修改 records/*.json;维护代码、删除或重命名文件需要人工审核。
  • review-service/src/worker.js: only added/modified records/*.json files qualify; maintenance, deletions, and renames need manual review.
    review-service/src/worker.js:自动审核仅支持新增或修改 records/*.json;维护代码、删除或重命名文件需要人工审核。
  • review-service/test/checks.test.js: only added/modified records/*.json files qualify; maintenance, deletions, and renames need manual review.
    review-service/test/checks.test.js:自动审核仅支持新增或修改 records/*.json;维护代码、删除或重命名文件需要人工审核。

What to do next

接下来怎么做

For file or commit errors, fix them on the same branch used by this PR and commit/push the changes. The check will rerun automatically. Keep this PR open; you do not need a new one.
如果是文件或提交问题,请在此 PR 对应的分支上修改并提交、推送,检查会自动重跑。请保留此 PR,无需重新申请。

If an error requires manual review, or you need help, leave a comment in this PR explaining the situation. A maintainer can review it or rerun the check; commenting alone does not clear the failed check.
如果错误提示需要人工审核,或您需要帮助,请在此 PR 下留言说明情况。管理员可以人工处理或重跑检查;仅留言不会消除失败状态。

Human review contact: @maoawa. This is an automated result, not their approval.
人工审核联系人:@maoawa。以上为自动检查结果,不代表该管理员已批准申请。

See the submission guide. Format checks do not assess website content or prove external domain ownership.
请参考申请指南。格式检查不会判断网站内容,也不能证明仓库之外的域名所有权。

Technical details / 技术详情

Checked revision ce9b564c2234048e248228d0dc504e3cc795bf50 against 1b99e4bb9b9301848fb8625e6439ce6820ad6c5a. Workflow run.
已检查提交 ce9b564c2234048e248228d0dc504e3cc795bf50,基准为 1b99e4bb9b9301848fb8625e6439ce6820ad6c5a。查看检查日志。

@maoawa
maoawa merged commit 0e99eb7 into main Sep 23, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant