Guide applicants in both languages and keep requested changes open - #43
Merged
Merged
Conversation
❌ Submission needs attentionChecked revision
Human review contact: @maoawa. This automated check is not their approval. See submission rules and the workflow run. Maintenance PRs and delegated submissions require manual review. This check does not verify website safety or prove domain ownership outside this repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicants receiving failed checks now get English/Chinese feedback with specific instructions to edit their PR description or push fixes to the same branch. Human requests for changes leave the PR open, post bilingual feedback with @maoawa attribution, and explain how to resubmit. The watch page and emails label this action “Request changes”.
Fix mail-browser form submissions rejected when their Origin is null or absent. Decisions still require a valid signed, expiring token; explicit foreign origins remain blocked. Description/title edits invalidate old links and issue a fresh review email even without a new commit, while used or uncertain decisions remain protected against duplicate writes.
Validation: 15 Node tests and 30 Worker tests pass; Wrangler deployment dry run passes. Regression coverage includes opaque-origin forms, token tampering, no PR closure, repeat decisions, updated descriptions and commits, and recovery locks. No real applicant PR was approved or rejected during testing.