Skip to content

Added Liked/Nope Font size to Options#103

Open
MatiBot wants to merge 1 commit into
modocache:masterfrom
MatiBot:master
Open

Added Liked/Nope Font size to Options#103
MatiBot wants to merge 1 commit into
modocache:masterfrom
MatiBot:master

Conversation

@MatiBot

@MatiBot MatiBot commented Sep 6, 2015

Copy link
Copy Markdown

No description provided.

@mabeebam

Copy link
Copy Markdown
Contributor

@MatiBot Thanks, exactly what I need too! Really looking forward to see your PR getting merged!

@MatiBot

MatiBot commented Oct 22, 2015

Copy link
Copy Markdown
Author

You can use my fork in the meantime

@mabeebam

Copy link
Copy Markdown
Contributor

@MatiBot I reference MDCSwipeToChoose via CocoaPods...
@modocache Any idea on when to merge the extensions from @MatiBot ?

@MatiBot

MatiBot commented Oct 22, 2015

Copy link
Copy Markdown
Author

pod 'MDCSwipeToChoose', :git => 'https://github.com/MatiBot/MDCSwipeToChoose.git', :commit => 'fef67df7a57373b6db821f503ca07b8c136dee64'

@mabeebam

Copy link
Copy Markdown
Contributor

@MatiBot Of course, did not think about that. Thanks for pointing out!

@MatiBot

MatiBot commented Oct 22, 2015

Copy link
Copy Markdown
Author

No problem

@vikmeup

vikmeup commented Oct 22, 2015

Copy link
Copy Markdown
Contributor

@MatiBot instead of passing CGFloat as a font size, it has to be UIFont, which will allow to set font as well. Consistency and best practices.
Could you please change that?

@mabeebam

Copy link
Copy Markdown
Contributor

@vikmeup Please check PR #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants