Repository navigation
docs(release): link the Prepare Python Release PR with addCloseIssueReferences - #5408
Conversation
…eferences Step 2c of the release skill now links the workflow-opened PR to the release issue and reads the link back (the pr-flow step 6 recipe), and says the by-hand fallback does the same. RELEASING.md says so next to the Version Packages sentence. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
|
There was a problem hiding this comment.
🟡 Changes recommended
The PR description and Closes #5334 claim security-advisory workflow changes that the release-documentation-only diff does not implement.
1 open issue
What changed in this PR
This PR documents explicit release-issue linking for Prepare Python Release PRs, aligning the release procedure with the repository’s v2/main tracking requirements.
Changes:
- Clarifies that Python release PRs retain
Closes #Nand also requireaddCloseIssueReferences. - Adds instructions to locate the generated PR, verify its issue link, and wait for dispatched checks before merging.
- Reinforces issue-link verification in the manual release fallback.
| File | Description |
|---|---|
| RELEASING.md | Clarifies Python release PR linkage in the release overview. |
| .claude/skills/release/SKILL.md | Adds explicit linking and verification steps for generated and manual Python release PRs. |
Review effort: Balanced
| 1. **Link it to the release issue.** Its `Closes #N` is only a | ||
| cross-reference on `v2/main`, and the workflow makes no API call, so link | ||
| it with the `addCloseIssueReferences` mutation from `/pr-flow` (step 6) | ||
| and read it back: `closingIssuesReferences` must list `#N`. On `v2/main` |
There was a problem hiding this comment.
Fixed (PR body edited; no code change). The body was overwritten by another session's draft for #5334 before the PR was opened: the agents shared a scratch file. The body now starts Closes #5335 and describes this release-documentation change. The API link was always to #5335 only (closingIssuesReferences reads [5335]), so nothing here was recorded against #5334.
|
Copilot round 1: one finding, no code changes.
The diff itself drew no findings. The only fix was to the PR body, and no commit was pushed, so there is nothing new for another round to review. The loop stops here. |

Closes #5335
Description
The release skill's step 2c (Prepare Python Release) now links the workflow-opened PR to the release issue with
addCloseIssueReferencesand reads the link back. It points at the/pr-flowstep 6 recipe rather than copying it, and adds a lookup that finds the PR by itsv2/chore/<N>-python-calver-branch. The by-hand fallback now says its/pr-flowstep 6 does the same link and read-back.RELEASING.mdsays it next to the Version Packages sentence and in the preparation-PR list.The workflow itself is unchanged. The issue makes that optional, so this PR keeps to the skill and the doc.
Server Details
releaseskill (step 2c only) andRELEASING.mdMotivation and Context
On
v2/main, aCloses #Nline is only a cross-reference. Nothing linked the Prepare Python Release PR through the API, unlike every other PR intov2/main(#5335).How Has This Been Tested?
This change has no client-observable surface, so the evidence is a targeted probe. I ran the new lookup against past Prepare Python Release PRs, with
--state allbecause they are merged (the skill lists open PRs), and it resolves the PR by its branch prefix. I then readclosingIssuesReferenceson #5336, the last such PR, which was linked to #5330 by hand. That read is the check the step now asks for:npm run local:gateexits 0. It includesverify:skillsandverify:skills:cli. The skill's description is unchanged, so noskills:evalrun is needed.Breaking Changes
None.
Types of changes
Checklist
npm run changeset) if this changes what a TypeScript server publishes (not applicable: nothing published changes)🤖 Generated with Claude Code