Repository navigation
Remove the @claude mention workflow (claude.yml) - #5407
Conversation
The maintainers do not use it, nearly every run it starts is a skip that clutters the Actions tab and PR checks, and it held ANTHROPIC_API_KEY. Delete the workflow and its trusted-author test, and drop the references in AGENTS.md (tree entry, Credentialed workflow jobs), verify-action-pins' header and sdk-watch.yml's secret comment. The historical design record in docs/agent-guidance-inception.md is left as written. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the removal of the unused @claude mention workflow.
No open issues 🎉
What changed in this PR
Removes the unused @claude mention workflow for #5337, reducing skipped Actions runs and credential exposure without changing any server package.
Changes:
- Deletes the mention-triggered workflow and its dedicated trusted-author tests.
- Removes obsolete workflow references and guidance; remaining workflow behavior is unchanged.
- Preserves historical documentation and the API secret usage required by SDK Watch.
| File | Description |
|---|---|
scripts/verify-action-pins.mjs |
Updates header examples of credentialed jobs; guard logic is unchanged. |
scripts/claude-workflow.test.mjs |
Deletes tests specific to the removed workflow. |
AGENTS.md |
Removes the workflow listing and its dedicated trusted-author rule. |
.github/workflows/sdk-watch.yml |
Removes an obsolete cross-reference from the secret’s comment. |
.github/workflows/claude.yml |
Deletes the @claude mention workflow. |
Review effort: Balanced
|
Copilot round 1: clean, with no findings and no suppressed comments. The loop stops at this first clean round (the Clean round exit in |
Closes #5337
Description
Removes the
@claudemention workflow and everything that existed only because of it:.github/workflows/claude.yml.scripts/claude-workflow.test.mjs, which evaluated that workflow's trusted-authorif:per event.scripts/verify-action-pins.mjs: the header no longer namesclaude.ymlas a credentialed job. Item 1 now lists onlyrelease.yml's publish jobs, and item 2 namessdk-watch.yml'sanalyzeandpost(the remainingANTHROPIC_API_KEYholders). No code path special-cased the file. The guard reads whatever workflows exist.AGENTS.md: drops theclaude.yml (@claude mentions)tree entry. Under Credentialed workflow jobs it dropsclaude.ymlfrom the list of credential holders and removes the "a credentialed job that a comment, review or issue can start runs only for a trusted author" bullet. With the workflow gone, no machinery is left for that bullet to describe ("every rule in this file is true of the repository as it stands")..github/workflows/sdk-watch.yml: the header comment no longer saysANTHROPIC_API_KEYis "the organization secretclaude.ymlalready uses". The secret stays, sinceanalyzeandpoststill use it.docs/agent-guidance-inception.mdis a historical design record, so its two mentions are left as written, as the issue allows.Server Details
AGENTS.mdMotivation and Context
See #5337. Almost every run of
claude.ymlwas a skip: any comment without a trusted@claudemention, bot comments included. Those skips cluttered the Actions tab and the PR checks and looked like stalled work during a release. The maintainers do not use the workflow, and it heldANTHROPIC_API_KEY, so removing it also removes credential surface.Scheduled and event workflows run from
main, so the runs stop at the next milestone merge, not when this merges tov2/main.How Has This Been Tested?
This change has no client-observable surface (workflows, guard comments, docs), so instead of client evidence it carries targeted probes:
git grep -n -e claude.yml -e claude-workflownow hits onlydocs/agent-guidance-inception.md(lines 81 and 669), the historical record.issue_comment,pull_request_revieworpull_request_review_commentto run Claude:git grep -n -e issue_comment -e pull_request_review -- .github/workflowsreturns nothing.npm run local:gateexits 0. That coverstest:scripts, now without the deleted test, andverify:action-pinsover the remaining workflows.Breaking Changes
None. No published package changes, and no client configuration is affected.
Types of changes
Checklist
ANTHROPIC_API_KEY)npm run changeset) if this changes what a TypeScript server publishes (not applicable: no published package changes)🤖 Generated with Claude Code