You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
release:notes: a gh reply over 1 MiB aborts the run with spawnSync ENOBUFS #5339
npm run release:notes aborts with release-notes: spawnSync gh ENOBUFS when any gh reply is larger than 1 MiB. run() in scripts/release-notes.mjs calls spawnSync with no maxBuffer, so Node's default of 1 MiB applies, and an overflow throws before any notes are produced. The preview and --draft both fail.
It first happened on the v2.2.0 release (#5330). The GraphQL query that lists the tree under src/ at the merge commit (expr=<merge-sha>:src) returned 1,087,532 bytes for 60200eb7. v2.1.0's tree was under the limit. The tree only grows, so every later release fails the same way.
The run completes. run() passes a maxBuffer large enough for any reply the script reads, for example 256 MiB. A test should show that a reply over 1 MiB gets through, and that a genuine spawn error is still rethrown.
Notes
For v2.2.0, the maintainer authorized drafting through a driver that calls the script's own main() with a spawn that retries an overflowing call with a larger buffer, so this fix was not required for that release.
scripts/lib/sweep.mjs's gh() helper, used by the sweeps, also calls spawnSync with no maxBuffer. Check whether any of its calls can grow past 1 MiB.
Activity