Skip to content

filesystem: list_directory_with_sizes reports an entry it could not stat as 0 B #5190

Closed

Description

@cliffhall

Problem

The list_directory_with_sizes handler in src/filesystem/server.ts catches a failed stat on an entry and substitutes a size of 0 and an mtime of the epoch. An unreadable entry, a dangling symlink, or a file removed between readdir and stat is therefore listed as 0 B and counted in the combined size, which makes it look like an empty file. src/filesystem/__tests__/server-tools.test.ts pins this behavior.

Expected

An entry that could not be stat'd is shown as unknown (or the failure is reported), rather than given an invented size, and is left out of the total. Any change to how this handler stats entries should be coordinated with other open work on the same handler.

Prior work

The PR(s) above targeted the pre-refactor code and are closed as part of the backlog triage in #4875; this issue is where the work continues, with the PR(s) as a prototype. Thank you to their authors.

Activity

  1. added
    bugSomething isn't working
    server-filesystemReference implementation for the Filesystem MCP server - src/filesystem
    on Oct 20, 2026
  2. cliffhall commented on Oct 20, 2026

    @cliffhall
    MemberAuthor

    Triage: Priority Low (total 5)

    • Severity 2: an unreadable entry is shown as an empty file
    • Urgency 2: wanted eventually
    • Bonuses:
    • +1 bug label

    Filed from the PR backlog triage (#4877). Board: Servers V2 (#43), Status Incoming, awaiting maintainer review (no milestone yet).

  3. added this to the v2.3.0 milestone on Oct 25, 2026
  4. self-assigned this
    on Oct 28, 2026
  5. cliffhall commented on Oct 29, 2026

    @cliffhall
    MemberAuthor

    Shipped in #5378, merged into v2/main; it releases with milestone v2.3.0. Tested together with the rest of the #5269 work in the rollup #5405.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingserver-filesystemReference implementation for the Filesystem MCP server - src/filesystemv2

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions