feat: SSE heartbeat#761
Conversation
ae7b4af to
29365d6
Compare
29365d6 to
e52f4ad
Compare
devcrocod
left a comment
There was a problem hiding this comment.
This PR adds the ktor api to the transport layer, which we would like to avoid since we plan to move away from a tight coupling with ktor.
Please consider using heartbeat only in the ktor dsl
The problem is that we can't access
Maybe I should remove the reference of |
Maybe I'm missing something, but couldn't we just pass an additional parameter and use the heartbeat in serverSSESession? That way, we wouldn't have to expose the ktor api in core. |
Summary
Adds optional SSE heartbeat configuration for streamable HTTP MCP server connections.
This lets
Application.mcpStreamableHttpcallers pass Ktor'sHeartbeatconfiguration for SSE streams, including heartbeat period and event payload. Heartbeats remain disabled by default, preserving the existing stream behavior unless the new option is explicitly provided.Motivation and Context
Some MCP clients need heartbeat messages on SSE connections to keep the connection alive. Without those heartbeats, the client may proactively disconnect from the MCP server. MCP server developers need a way to configure an SSE heartbeat mechanism so they can avoid unexpected client disconnects.
In my case, my MCP server was consistently disconnected by Gemini CLI. I worked around the issue with some fallback approaches, but I believe the best implementation is to add heartbeat support by using Ktor's built-in API.
My solution:
Implementation Notes
sseHeartbeatConfig: (Heartbeat.() -> Unit)? = nullparameter toApplication.mcpStreamableHttp.StreamableHttpServerTransport.Configuration.sse { ... }block before handling the existing streamable HTTP transport request.How Has This Been Tested?
Added
StreamableHttpHeartbeatTestcovering:sseHeartbeatConfigis omitted.Verified locally with:
./gradlew :kotlin-sdk-server:jvmTest --tests "io.modelcontextprotocol.kotlin.sdk.server.StreamableHttpHeartbeatTest"Result:
BUILD SUCCESSFUL.Breaking Changes
No source-level breaking changes are expected. The new heartbeat option is nullable and defaults to
null, so existingmcpStreamableHttpcalls continue to use the previous behavior with no heartbeat.This PR does update the public API surface by adding an optional parameter and configuration property.
Types of changes
Checklist
Additional context
Heartbeat behavior is delegated to Ktor's SSE heartbeat support, so applications can use the same configuration semantics they would use in native Ktor SSE routes.
Related issue: SSE needs a heartbeat #344