Add scenario-aware speed modifiers - #406
Open
FlxPo wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
==========================================
+ Coverage 83.20% 83.33% +0.12%
==========================================
Files 234 235 +1
Lines 16294 16371 +77
==========================================
+ Hits 13558 13643 +85
+ Misses 2736 2728 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Road network modifiers only accepted fixed values. Border penalties, speed limits, lane changes, and new roads could therefore not change by scenario or model iteration.
Passing a
ParameterValuedirectly also left it unresolved when the graph was built, which caused serialization errors.Changes
ParameterValueandSensitivityValue, including geometry paths and extract dates.Example (if relevant)
AI-assisted contribution
Select one:
AI assistance covered the architecture, implementation, tests, documentation, and PR draft. The resulting resolved variants, lazy asset behavior, scalar compatibility, public attributes, and cache inputs were reviewed.
Validation included:
git diff --checkChecklist