Repository navigation
Conversation
The Defaults entry passed "⊞" as its icon name, so every startup asked the icon theme for a non-existent icon and logged a warning, and the chip reserved an empty 16px slot for it. AppProfileBar now draws a 2x2 "all applications" grid for the Defaults chip in the label colour, so it follows the theme and the active-chip colours. ProfileModel no longer gives Defaults a theme icon name. Chip width now comes from the content row, which skips hidden children, so chips whose theme icon fails to load no longer keep a gap either. Tests: ProfileModel checks Defaults has no icon name; new tst_AppProfileBar.qml checks the Defaults mark and chip widths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every startup logged a warning because the Defaults profile asked the icon theme for an icon named
⊞, which isn't an icon name. The chip also left an empty 16px space where that icon would have gone.AppProfileBar.qmldraws a 2×2 "all applications" grid for the Defaults chip. It uses the label colour, so it matches the theme and turns the active-chip text colour when the tab is selected. No icon theme has a name for this on every desktop, which is why it's drawn rather than looked up.ProfileModelno longer gives Defaults a theme icon name, so the lookup and the warning are gone.Tests
test_profile_model.cpp:DefaultEntrynow checks that Defaults has no icon name.tests/qml/tst_AppProfileBar.qml:⊞warning in the log since launch. Rendered chips checked in dark and light themes, active and inactive.🤖 Generated with Claude Code