Repository navigation
Conversation
Each gesture-trigger button keeps its own direction map (Options+-style) instead of sharing one profile-wide Gestures section.
mmaher88
requested changes
Nov 9, 2026
mmaher88
left a comment
Owner
There was a problem hiding this comment.
Thanks, this closes #122 nicely, and the migration from the old flat [Gestures] keys and its tests are solid. Since #174 landed, a few things need attention on rebase:
ButtonActionDispatcher.cppmerges without a git conflict but still usesm_currentDevice, which no longer exists. Instead of looking up a descriptor on release, please record the button index in the per-device state when the gesture button is pressed and use that.- In
setupProfileForDevice, seed from the connecting device'sdescriptor, notm_currentDevice. - Update
tests/test_device_routing.cpp, which still uses.gestures. - In
saveCurrentProfile, movep.buttonGestures.clear()inside them_currentDeviceguard, so a save without a descriptor can't wipe every map.
For downgrades, could you keep writing the flat [Gestures] keys (mirroring the lowest gesture button) for a release or two? Older builds would then keep working instead of erasing the nested keys on their next save. If #168 merges first, please route its drag path through the same per-button lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[Gestures]profiles migrate by copying the shared map onto everygesture-triggerbutton.defaultGestures.Test plan
[Gestures/<buttonIndex>/…][Gestures]keys — both gesture buttons still work, then diverge after editinglogitune-testsfilters for*Gesture*,ProfileEngine.*,DeviceModelTest.*Gesture*pass