Repository navigation
Conversation
Hold-to-scrub on GNOME Wayland with release snap, configurable direction and commit threshold, so MX Master users can switch desktops the same way they do in Logi Options+.
mmaher88
requested changes
Nov 9, 2026
mmaher88
left a comment
Owner
There was a problem hiding this comment.
This is an ambitious feature, and the HID++ 0x2150 Stop/touch parsing is a nice addition. It's a lot for one PR, though. Could you split it into:
- (a) the 0x2150 event parsing and
thumbWheelReleased, which is close to mergeable; - (b) a "Switch desktops" mode that works on any desktop through the presets;
- (c) the GNOME interactive extension.
Blocking issues:
- The RPM
%filesinpkg/obs/logitune.specmust list the newlogitune-workspace@folder, or the OBS builds fail. - Every
qBoundcall has its arguments reversed (Qt's order isqBound(min, value, max)), which asserts in debug builds for values over 90. findExtensionSourceDirhas fallbacks that ignore the extension ID, so it can copy the workspace extension overlogitune-focus@.- The refactor drops the stale user-copy cleanup from 3f03e55.
On design:
- C++ and the extension each track progress, but only the Shell clamps at the first and last workspace, so snapping goes wrong after overshooting an edge. Please let the extension own progress, take
snapPercentinEnd, and drop the C++ easing. - End an active scrub whenever Stop arrives or a profile is applied, whatever the current mode, and add a watchdog in the extension (or watch our D-Bus name) so the Shell can't be left mid-switch.
- The preset fallback switches a desktop every 15 thumb units, which jumps several desktops per flick. Please use a much larger step or one switch per roll, and hide the mode on desktops that can't do it.
- The extension uses private Shell internals and is installed for every GNOME user at start-up. Please make it opt-in when the mode is selected, and list only the Shell versions you've tested.
After that, a rebase onto #174's per-device slots is needed (PhysicalDevice* arguments and a lambda in AppRoot).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x2150Stop/touch so release ends the gesture; eases to the threshold target before finishing so the lift-off animation stays smooth.Test plan
logitune-workspace@logitune.com(or let Logitune sync/enable it)logitune-testsfilterButtonActionDispatcherFixture.Workspace*/ThumbWheel.ParseEvent*pass