[FIX] Show leave confirmation and prevent redundant requests when navigating away from in-progress function creation#3729
Open
amit-noy wants to merge 11 commits into
Open
[FIX] Show leave confirmation and prevent redundant requests when navigating away from in-progress function creation#3729amit-noy wants to merge 11 commits into
amit-noy wants to merge 11 commits into
Conversation
<!-- Title structure should start with a flag - either of these: [FEAT] [FIX] [CHORE] [CI] [DOCS] [STYLE] [REFACTOR] [TEST] [BUILD] [PERF] Followed by a clear representation - e.g: [STYLE] Reformat components for linting compliance [CI] Run tests on push for all branches [FEAT] Add dark mode toggle in header --> ## 📝 Description <!-- A clear, concise summary of what this PR does. --> <!-- Include context, motivation, or related issues (e.g., "Replaces Sass with CSS Modules"). --> When a user had an item's detail pane or version history open (on Jobs, Real-time pipelines, or Artifacts pages) and switched projects via the sidebar dropdown, the URL was naively replacing the project name in place. This kept the artifact/item-specific segments in the URL, causing the next network request to still reference the previous project's item instead of loading a clean state for the new project. The fix strips artifact-specific path segments on project switch, so the user always lands on the section's main list of the new project with no leftover item context. --- ## 🛠️ Changes Made <!-- List the main updates in this PR. --> <!-- Example: - Replaced Sass styles with CSS Modules - Updated Button component props for accessibility - Adjusted CI workflow to run on push for all branches --> - `ProjectDropdown.jsx`: compute `basePath` before building project links - when the current path is deeper than depth 5 (i.e. an item is selected), strip back to `/projects/:projectName/:section` - `ProjectDropdown.test.jsx`: added `EllipsisTooltip` to the mock (was missing) and a new `project switch navigation` describe block with 7 test cases covering flat sections (depth 4), sub-tab main pages (depth 5), and selected-item pages (depth 6+) --- ## ✅ Checklist - [x] I have given the PR a well-structured title describing the domain and the specific change that was made - [x] I tested the changes in the browser (locally or via preview build) - [x] I confirmed that existing tests pass - [x] I added or updated unit / integration tests (if needed) - [x] I checked that this change doesn’t introduce new console warnings or lint / formatting errors - [x] I updated the relevant Jira ticket with the appropriate details and status --- ## 🔗 References - Related ticket / issue: https://ecliptos.atlassian.net/browse/ML-12831 - Figma / design spec: - Documentation: --- ## 🚨 Potentially Breaking Changes - [ ] Yes - [x] No <!-- If yes, describe what breaks and how to migrate: --> <!-- Example: Renamed prop `variant` → `type` in Button component --> --- Includes DRC change - [ ] Yes - [x] No If yes -> requires bump NPM version --- ## 🔍 Additional Notes <!-- Optional: other context, performance considerations, or follow-up work --> <!-- Example: - TODO: Migrate remaining components away from Sass - Known issue: minor layout flicker on mobile --> --- ## 📸 Screenshots / Demos <!-- Include before/after screenshots, GIFs, or video demos if the change affects UI. --> <!-- You can drag and drop images here directly in the PR. --> ---
Taras-Hlukhovetskyi
approved these changes
Jul 16, 2026
… mlrun-ui - vite.config.mjs: add react-router-dom as MF singleton so all apps share one router instance - App.jsx: detect when loaded inside a host router (useInRouterContext) and render <Routes> instead of <RouterProvider> to avoid nested-router crash Co-authored-by: Cursor <cursoragent@cursor.com>
…bar close on block - RemoteNuclioRouteWrapper: remove synthetic popstate dispatch and isNuclioPath (no longer needed with shared singleton router) - RemoteNuclioRouteWrapper: close sidebar via igz:navigation-blocked onBlock callback - Remove HostLeaveGuard (Nuclio's useBlocker handles all navigation directly) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
when navigating away from an in-progress (unsaved) function creation page via the sidebar or breadcrumbs, the "Leave without deploying?" confirmation dialog was not shown. As a side effect, the function page was unmounting and remounting, causing the functions list request and the function name validation request to fire redundantly.
Root cause:
igz4-nuclio,mlrun-ui, andigz4-uieach had their ownRouterProviderand browser history instance. Three routers were competing overwindow.history, so Nuclio'suseBlockerwas firing on the wrong router - the leave dialog never appeared on browser back, and navigations from the host's sidebar/breadcrumbs bypassed the blocker entirely.Fix: Share
react-router-domas a singleton across all apps. Since React Router throws when two providers share the same history,mlrun-uiusesuseInRouterContext()to detect if it's embedded insideigz4-uiand renders<Routes>instead of a fullRouterProviderin that case - plugging its route tree directly into the host's existing router context so all navigation is handled by a single history instance.🛠️ Changes Made
vite.config.mjs- sharereact-router-domas a singleton so all federated apps use one history instanceApp.jsx- detect embedded mode viauseInRouterContext(); render<Routes>instead ofRouterProviderwhen hosted inside igz4-ui; stabilize router instance withuseRefRemoteNuclioRouteWrapper.jsx- registerwindow.__igzLeaveGuard.onBlockto close the sidebar when Nuclio blocks a navigation; remove the syntheticpopstatedispatch that was causing duplicate requestsHostLeaveGuard- deleted; Nuclio's ownuseBlockernow handles all navigation types including browser back/forward✅ Checklist
🔗 References
🚨 Potentially Breaking Changes
Includes DRC change
If yes -> requires bump NPM version
🔍 Additional Notes
This PR is part of a multi-repo leave-guard integration
📸 Screenshots / Demos