Repository navigation
ci: delete the crates.io publish job - #45
Merged
Merged
Conversation
The maintainer ruled out publishing iggy_sample to crates.io, which resolves TD-2026-09-04 with its first option. The job could not succeed (no CRATES_IO_TOKEN, and publish = false) and failed on every stable release under continue-on-error, so it only added a masked failed step and a secret reference that invited configuring a live token. publish = false stays as the guard, and no workflow references the secret now. Verify Release checks each run against the release.yml that run used, so the stable releases up to v0.4.1 still fail it on that step. For a release.yml without the job, the verifier now PASSes "no publish job" against publish = false instead of skipping, and "every job succeeded" drops its exception. The verifier's and the workflow's headers, CONTRIBUTING, Cargo.toml's comment and the changelog say so, the record is resolved, and TD-2026-09-05's pin count drops to 16 with the job's rust-cache pin. Checked: v0.4.1 unchanged (40/1/0); with the job detection forced off, the same run gives "PASS no publish job ..." and "PASS every job succeeded".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes release.yml's crates.io publish job: iggy_sample is not published to
crates.io, so this resolves TD-2026-09-04 with its first option. The job could
not succeed (no
CRATES_IO_TOKEN, andpublish = false) and failed on everystable release, hidden by
continue-on-error.Type of Change
Changes Made
CRATES_IO_TOKEN.publish = falsestays as the guard.against
publish = false(was a SKIP), and "every job succeeded" drops itsexception. Runs up to v0.4.1 are checked against their own release.yml, so
they still FAIL on the masked step, as before.
workflow headers, CONTRIBUTING, Cargo.toml's comment and the changelog
(a Removed entry) updated; TD-2026-09-05's pin count is 16 now.
Testing
Checklist
Documentation
Security