Repository navigation
Switch CodeQL to advanced setup and ignore tests - #268
Merged
Merged
Conversation
Default setup can't take a config file, so test assertions like `"sftp.example.com:2222" in details` were raising py/incomplete-url-substring-sanitization alerts. Add a CodeQL workflow covering the same languages as default setup (actions, javascript-typescript, python) with paths-ignore for tests/.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #268 +/- ##
========================================
Coverage 80.85% 80.85%
========================================
Files 144 144
Lines 13748 13748
========================================
Hits 11116 11116
Misses 2632 2632
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/codeql.ymlto replace CodeQL default setup. It scans the same languages (actions,javascript-typescript,python) withbuild-mode: noneon a weekly schedule, plus push and PR runs ondevelop..github/codeql/codeql-config.ymlwithpaths-ignore: [tests]. Default setup doesn't accept a config file, so test assertions such asassert "sftp.example.com:2222" in detailswere raisingpy/incomplete-url-substring-sanitizationalerts (8 open, all undertests/).permissions: {}at the top level, scoped job permissions, SHA-pinned actions, harden-runner, andpersist-credentials: false.Before merging
Turn off default setup (Settings → Code security → CodeQL analysis → switch to Advanced). While it's on, uploads from this workflow are rejected.
After this workflow's first run on
develop, the 8 test alerts should close automatically.🤖 Generated with Claude Code
Summary by CodeRabbit