Add PopulationProxyTargets (proxy target overfitting bias) - #36
Open
eltonbaidoo wants to merge 2 commits into
Open
Add PopulationProxyTargets (proxy target overfitting bias)#36eltonbaidoo wants to merge 2 commits into
eltonbaidoo wants to merge 2 commits into
Conversation
eltonbaidoo
requested review from
brownsarahm and
Copilot
and removed request for
Copilot
July 16, 2026 17:04
brownsarahm
requested changes
Jul 27, 2026
brownsarahm
left a comment
brownsarahm
left a comment
Collaborator
There was a problem hiding this comment.
I have made one small change naming wise, but also @surbhir08 will your refactor be able to capture this functionality?
| feature_noise_sampler=FeatureNoise()): | ||
| self.demographic_sampler = demographic_sampler | ||
| self.target_sampler = target_sampler | ||
| self.feature_sampler = feature_sampler_true |
Collaborator
There was a problem hiding this comment.
Suggested change
| self.feature_sampler = feature_sampler_true | |
| self.feature_sampler_target = feature_sampler_target |
There was a problem hiding this comment.
@brownsarahm I have FeatureConditionerZ, which can be used for xz conditioning, but I don't have anything explicitly for xy. We can add FeatureConditionerY following the same pattern and then it can work with param mixins that we have or we can add Elton's code.
| a, z = self.demographic_sampler.sample(N) | ||
| y = self.target_sampler.sample(a, z) | ||
|
|
||
| x_true = self.feature_sampler.sample(a, z, y) |
Collaborator
There was a problem hiding this comment.
Suggested change
| x_true = self.feature_sampler.sample(a, z, y) | |
| x_true = self.feature_sampler_target.sample(a, z, y) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PopulationProxyTargets, aPopulationsubclass that generates data withproxy target overfitting bias